Skip to content

Commit 77af54d

Browse files
committed
apply review feedback
1 parent 1f27265 commit 77af54d

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

core/Tracker/BotRequest.php

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111

1212
namespace Piwik\Tracker;
1313

14-
use Piwik\Common;
15-
use Piwik\Container\StaticContainer;
14+
use Piwik\Log\LoggerInterface;
15+
use Piwik\Plugin\RequestProcessors;
1616

1717
/**
1818
* Class used to handle a Bot request.
@@ -36,11 +36,16 @@ class BotRequest
3636
*/
3737
protected $requestProcessors;
3838

39-
public function __construct()
39+
/**
40+
* @var LoggerInterface
41+
*/
42+
protected $logger;
43+
44+
public function __construct(RequestProcessors $requestProcessors, LoggerInterface $logger)
4045
{
41-
$requestProcessors = StaticContainer::get('Piwik\Plugin\RequestProcessors');
4246
$this->requestProcessors = $requestProcessors->getRequestProcessors();
4347
$this->botRequestProcessors = $requestProcessors->getBotRequestProcessors();
48+
$this->logger = $logger;
4449
}
4550

4651
/**
@@ -61,13 +66,13 @@ public function handle()
6166
* @deprecated
6267
*/
6368
foreach ($this->requestProcessors as $processor) {
64-
Common::printDebug("Executing " . get_class($processor) . "::manipulateRequest()...");
69+
$this->logger->debug("Executing " . get_class($processor) . "::manipulateRequest()...");
6570

6671
$processor->manipulateRequest($this->request);
6772
}
6873

6974
foreach ($this->botRequestProcessors as $processor) {
70-
Common::printDebug("Executing " . get_class($processor) . "::manipulateRequest()...");
75+
$this->logger->debug("Executing " . get_class($processor) . "::manipulateRequest()...");
7176

7277
$processor->manipulateRequest($this->request);
7378
}
@@ -77,7 +82,7 @@ public function handle()
7782
$wasHandled = false;
7883

7984
foreach ($this->botRequestProcessors as $processor) {
80-
Common::printDebug("Executing " . get_class($processor) . "::handleRequest()...");
85+
$this->logger->debug("Executing " . get_class($processor) . "::handleRequest()...");
8186

8287
$wasHandled |= $processor->handleRequest($this->request);
8388
}

0 commit comments

Comments
 (0)