rewrote line break determination code

Author: matortheeternal

src/ini.js

@@ -1,3 +1,5 @@
+const systemLineBreak = process && process.platform === 'win32' ? '\r\n' : '\n';
+
 class Ini {
     static merge(...inis) {
         let mergeLines = (section, newSection) => {
@@ -32,7 +34,7 @@ class Ini {
     constructor(text = '', lineBreak) {
         if (typeof text !== 'string')
             throw new Error('Input must be a string.');
-        this.lineBreak = lineBreak || this.determineLineBreak(text)
+        this.lineBreak = lineBreak || this.determineLineBreak(text);
         this.sections = [];
         let currentSection = this.globals = new IniSection();
         if (text.length === 0) return;
@@ -47,23 +49,9 @@ class Ini {
     }
 
     determineLineBreak(text) {
-        if(text === '') {
-            return typeof process !== 'undefined' &&
-                process.platform === 'win32' ? '\r\n' : '\n'
-        } else {
-            let lineBreak
-            if(['\r\n', '\n'].some((t) => {
-                if (text.split(t).length > 1) {
-                    lineBreak = t
-                    return true
-                }
-            })) {
-                return lineBreak
-            } else {
-                return typeof process !== 'undefined' &&
-                    process.platform === 'win32' ? '\r\n' : '\n'
-            }
-        }
+        return ['\r\n', '\n'].find(lineBreak => {
+            return text.includes(lineBreak);
+        }) || systemLineBreak;
     }
 
     getSection(name) {

test/ini.test.js

@@ -44,6 +44,32 @@ describe('Ini', function() {
                 expect(foo.stringify()).toBe(text);
             });
         });
+
+        describe('line break parameter', function() {
+            it('should use parameter if passed', () => {
+                let newIni = new Ini('[x]\r\nb=3', '\r\n');
+                expect(newIni.sections[0].lines.length).toBe(2);
+
+                let newIni2 = new Ini('[x]\nb=3', '\r\n');
+                expect(newIni2.sections[0].lines.length).toBe(1);
+            });
+
+            describe('not passed', () => {
+                it('should determine from text', () => {
+                    let newIni = new Ini('[x]\r\nb=3');
+                    expect(newIni.sections[0].lines.length).toBe(2);
+
+                    let newIni2 = new Ini('[x]\nb=3');
+                    expect(newIni2.sections[0].lines.length).toBe(2);
+                });
+
+                it('should determine by system if cannot determine by text', () => {
+                    let newIni = new Ini('[x]=3');
+                    let linebreak = process.platform === 'win32' ? '\r\n' : '\n';
+                    expect(newIni.lineBreak).toBe(linebreak);
+                });
+            });
+        });
     });
 
     describe('addSection', function() {
@@ -173,28 +199,4 @@ describe('Ini', function() {
             });
         });
     });
-
-    describe('linebreak', function() {
-        it('should accept linebreak', () => {
-            const newIni = new Ini('[x]\r\nb=3', '\r\n')
-            expect(newIni.sections[0].lines.length).toBe(2)
-
-            const newIni2 = new Ini('[x]\nb=3', '\r\n')
-            expect(newIni2.sections[0].lines.length).toBe(1)
-        })
-
-        it('should determind linebreak by text', () => {
-            const newIni = new Ini('[x]\r\nb=3')
-            expect(newIni.sections[0].lines.length).toBe(2)
-
-            const newIni2 = new Ini('[x]\nb=3')
-            expect(newIni2.sections[0].lines.length).toBe(2)
-        })
-
-        it('should determind linebreak by system when by text fail', () => {
-            const newIni = new Ini('[x]=3')
-            const linebreak = process.platform === 'win32' ? '\r\n' : '\n'
-            expect(newIni.lineBreak).toBe(linebreak)
-        })
-    }) 
-});
+});