Skip to content

Commit 5c5e8ce

Browse files
authored
Pin the Node minor version for Docker builds (#949)
* Pin the Node minor version for Docker builds as 20.13 & 20.14 cause Hookshot to crash on startup (at least on arm64) * Add changelog
1 parent 5dae23b commit 5c5e8ce

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Stage 0: Build the thing
22
# Need debian based image to build the native rust module
33
# as musl doesn't support cdylib
4-
FROM node:20-slim AS builder
4+
FROM node:20.12-slim AS builder
55

66
# Needed in order to build rust FFI bindings.
77
RUN apt-get update && apt-get install -y build-essential cmake curl pkg-config pkg-config libssl-dev
@@ -29,7 +29,7 @@ RUN yarn build
2929

3030

3131
# Stage 1: The actual container
32-
FROM node:20-slim
32+
FROM node:20.12-slim
3333

3434
WORKDIR /bin/matrix-hookshot
3535

changelog.d/949.misc

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Pin the minor version of Node for Docker builds to avoid a startup crash on arm64.

0 commit comments

Comments
 (0)