Allow port differing in OIDC dynamic registration URIs (#4749)

As per discussion and amendment to matrix-org/matrix-spec-proposals#2966

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Author: t3chguy

spec/unit/oidc/register.spec.ts

@@ -32,6 +32,7 @@ describe("registerOidcClient()", () => {
         tosUri: "https://just.testing/tos",
         policyUri: "https://policy.just.testing",
         contacts: ["admin@example.com"],
+        logoUri: `${baseUrl}:8443/logo.png`,
     };
     const dynamicClientId = "xyz789";
 
@@ -69,6 +70,7 @@ describe("registerOidcClient()", () => {
                 application_type: "web",
                 tos_uri: "https://just.testing/tos",
                 policy_uri: "https://policy.just.testing",
+                logo_uri: `${baseUrl}:8443/logo.png`,
             }),
         );
     });

src/oidc/register.ts

@@ -59,7 +59,7 @@ const urlHasCommonBase = (base: URL, urlStr?: string): boolean => {
     if (!urlStr) return false;
     const url = new URL(urlStr);
     if (url.protocol !== base.protocol) return false;
-    if (url.host !== base.host && !url.host.endsWith(`.${base.host}`)) return false;
+    if (url.hostname !== base.hostname && !url.hostname.endsWith(`.${base.hostname}`)) return false;
     return true;
 };