Log errors during start-up and fix the default logging config (#122)

Author: clokep

changelog.d/122.bugfix

@@ -0,0 +1 @@
+Log errors during start-up.

sygnal.yaml.sample

@@ -97,6 +97,8 @@ log:
       handlers: ["stderr"]
       level: "INFO"
 
+    disable_existing_loggers: false
+
 
   access:
     # Specify whether or not to trust the IP address in the `X-Forwarded-For`

sygnal/sygnal.py

@@ -28,9 +28,10 @@
 import yaml
 from opentracing.scope_managers.asyncio import AsyncioScopeManager
 from twisted.enterprise.adbapi import ConnectionPool
-from twisted.internet import asyncioreactor
+from twisted.internet import asyncioreactor, defer
 from twisted.internet.defer import ensureDeferred
 from twisted.python import log as twisted_log
+from twisted.python.failure import Failure
 
 from sygnal.http import PushGatewayApiServer
 
@@ -133,10 +134,9 @@ def __init__(self, config, custom_reactor, tracer=opentracing.tracer):
                     )
                     raise
             else:
-                logger.error(
+                raise RuntimeError(
                     "Unknown OpenTracing implementation: %s.", tracecfg["impl"]
                 )
-                sys.exit(1)
 
         db_name = config["database"]["name"]
 
@@ -190,14 +190,14 @@ async def _make_pushkins_then_start(self, port, bind_addresses, pushgateway_api)
             try:
                 self.pushkins[app_id] = await self._make_pushkin(app_id, app_cfg)
             except Exception:
-                logger.exception(
+                raise RuntimeError(
                     "Failed to load and create pushkin for kind %s", app_cfg["type"]
                 )
-                sys.exit(1)
 
         if len(self.pushkins) == 0:
-            logger.error("No app IDs are configured. Edit sygnal.yaml to define some.")
-            sys.exit(1)
+            raise RuntimeError(
+                "No app IDs are configured. Edit sygnal.yaml to define some."
+            )
 
         logger.info("Configured with app IDs: %r", self.pushkins.keys())
 
@@ -213,9 +213,25 @@ def run(self):
         bind_addresses = self.config["http"]["bind_addresses"]
         pushgateway_api = PushGatewayApiServer(self)
 
-        ensureDeferred(
-            self._make_pushkins_then_start(port, bind_addresses, pushgateway_api)
-        )
+        @defer.inlineCallbacks
+        def start():
+            try:
+                yield ensureDeferred(
+                    self._make_pushkins_then_start(
+                        port, bind_addresses, pushgateway_api
+                    )
+                )
+            except Exception:
+                # Print the exception and bail out.
+                print("Error during startup:", file=sys.stderr)
+
+                # this gives better tracebacks than traceback.print_exc()
+                Failure().printTraceback(file=sys.stderr)
+
+                if self.reactor.running:
+                    self.reactor.stop()
+
+        self.reactor.callWhenRunning(start)
         self.reactor.run()