Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Synapse accepts /forget without a request body but this is not meant to be allowed by the specification #16366

Open
Open
Synapse accepts /forget without a request body but this is not meant to be allowed by the specification#16366
Labels
A-Spec-Complianceplaces where synapse does not conform to the specO-UncommonMost users are unlikely to come across this or unexpected workflowS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.Z-Future-MaintenanceThings that can't yet be done, but will need cleaning up in a couple of months/releases

Description

@reivilibre
reivilibre
opened on Sep 22, 2023

Like all PUT and POST requests other than the media ones (and /logout...), /forget is supposed to take a JSON body, e.g. {} if nothing special is required. Currently Synapse as at v1.92.3 does not require this.

#16365 adds a warning against this.

We should see if any clients are hitting this and then a future version should cut this off completely.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-Spec-Complianceplaces where synapse does not conform to the specO-UncommonMost users are unlikely to come across this or unexpected workflowS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.Z-Future-MaintenanceThings that can't yet be done, but will need cleaning up in a couple of months/releases

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions