fix(evm): clean up interface for deploy-time linking (#320)

Author: hedgar2017

Cargo.lock

@@ -26,7 +26,7 @@ pub struct Object {
     pub metadata_bytes: Option<Vec<u8>>,
     /// Dependencies.
     pub dependencies: era_yul::Dependencies,
-    /// The unlinked unlinked libraries.
+    /// The unlinked libraries.
     pub unlinked_libraries: BTreeSet<String>,
     /// Whether the object is already assembled.
     pub is_assembled: bool,

era-compiler-solidity/src/build_evm/contract/object.rs

@@ -338,8 +338,7 @@ impl Contract {
                     .map_err(|error| {
                         anyhow::anyhow!("{runtime_code_segment} code LLVM IR generator: {error}")
                     })?;
-                let runtime_build =
-                    runtime_context.build(false, true, unlinked_libraries.clone())?;
+                let runtime_build = runtime_context.build(false, true)?;
                 let runtime_object = EVMContractObject::new(
                     runtime_code_identifier,
                     self.name.clone(),
@@ -379,7 +378,7 @@ impl Contract {
                     .map_err(|error| {
                         anyhow::anyhow!("{deploy_code_segment} code LLVM IR generator: {error}")
                     })?;
-                let deploy_build = deploy_context.build(false, true, unlinked_libraries.clone())?;
+                let deploy_build = deploy_context.build(false, true)?;
                 let deploy_object = EVMContractObject::new(
                     deploy_code_identifier,
                     self.name.clone(),
@@ -436,8 +435,7 @@ impl Contract {
                     .map_err(|error| {
                         anyhow::anyhow!("{runtime_code_segment} code LLVM IR generator: {error}")
                     })?;
-                let runtime_build =
-                    runtime_context.build(false, true, unlinked_libraries.clone())?;
+                let runtime_build = runtime_context.build(false, true)?;
                 let runtime_object = EVMContractObject::new(
                     runtime_code_identifier,
                     self.name.clone(),
@@ -473,7 +471,7 @@ impl Contract {
                     .map_err(|error| {
                         anyhow::anyhow!("{deploy_code_segment} code LLVM IR generator: {error}")
                     })?;
-                let deploy_build = deploy_context.build(false, true, unlinked_libraries.clone())?;
+                let deploy_build = deploy_context.build(false, true)?;
                 let deploy_object = EVMContractObject::new(
                     deploy_code_identifier,
                     self.name.clone(),
@@ -540,8 +538,7 @@ impl Contract {
                     optimizer.clone(),
                     debug_config.clone(),
                 );
-                let runtime_build =
-                    runtime_context.build(false, true, unlinked_libraries.clone())?;
+                let runtime_build = runtime_context.build(false, true)?;
                 let runtime_object = EVMContractObject::new(
                     runtime_code_identifier,
                     self.name.clone(),
@@ -567,7 +564,7 @@ impl Contract {
                     optimizer,
                     debug_config,
                 );
-                let deploy_build = deploy_context.build(false, true, unlinked_libraries.clone())?;
+                let deploy_build = deploy_context.build(false, true)?;
                 let deploy_object = EVMContractObject::new(
                     deploy_code_identifier,
                     self.name.clone(),