Remove unneeded pausing logic (#2040)

# What ❔

This is a sister PR to:
matter-labs/zksync-era#4674

1. Since stage1 is not supported for chains on top of GW, there is no
need to wait before l1->l2 ops can be paused (as there is always the
transaction filterer approach).
2. We do not automatically re-enable deposits in 1.5 days since GW is
expected to return a confirmation message. l1->l2 ops are unpaused only
via the confirmation message (or chain admin but only if no withdrawal
happened)

There is a known issue preventing stage1: 
- Chain admin may pause deposits, but not actually try to migrate.
- So in the future we will need to reintroduce
CHAIN_MIGRATION_TIME_WINDOW_END_MAINNET/PAUSE_DEPOSITS_TIME_WINDOW_END_MAINNET,
but we will have to carefully consider the used timelines to ensure that
stage1 works.
- This not an issue in this release, since we dont support stage1 for
chains on GW

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.

---------

Co-authored-by: zksync[bot] <zksync[bot]@users.noreply.github.com>

Author: StanislavBreadless

AllContractsHashes.json

@@ -214,24 +214,16 @@ uint256 constant PACKED_L2_PRECOMMITMENT_LENGTH = 33;
 L2DACommitmentScheme constant ROLLUP_L2_DA_COMMITMENT_SCHEME = L2DACommitmentScheme.BLOBS_AND_PUBDATA_KECCAK256;
 
 /// @dev The start of the pause deposits time window. We pause when migrating to/from gateway.
-uint256 constant PAUSE_DEPOSITS_TIME_WINDOW_START_MAINNET = 3 days + 12 hours;
+/// @dev It is set to 0 in this release, since stage1 is not yet supported for chains that settle on top of ZK Gateway.
+uint256 constant PAUSE_DEPOSITS_TIME_WINDOW_START_MAINNET = 0;
 
-/// @dev The start of the chain migration window, it equals the PAUSE_DEPOSITS_TIME_WINDOW_START.
-uint256 constant CHAIN_MIGRATION_TIME_WINDOW_START_MAINNET = 3 days + 12 hours;
+/// @dev The delay from `pausedDepositsTimestamp` from which the migration is allowed. It equals the PAUSE_DEPOSITS_TIME_WINDOW_START.
+/// @dev It is set to 0 in this release, since stage1 is not yet supported for chains that settle on top of ZK Gateway.
+uint256 constant CHAIN_MIGRATION_TIME_WINDOW_START_MAINNET = 0;
 
-/// @dev The end of the chain migration window.
-uint256 constant CHAIN_MIGRATION_TIME_WINDOW_END_MAINNET = 4 days + 12 hours;
+uint256 constant PAUSE_DEPOSITS_TIME_WINDOW_START_TESTNET = 0;
 
-/// @dev The end of the pause deposits time window. We pause when migrating to/from gateway.
-uint256 constant PAUSE_DEPOSITS_TIME_WINDOW_END_MAINNET = 7 days;
-
-uint256 constant PAUSE_DEPOSITS_TIME_WINDOW_START_TESTNET = 1;
-
-uint256 constant CHAIN_MIGRATION_TIME_WINDOW_START_TESTNET = 1;
-
-uint256 constant CHAIN_MIGRATION_TIME_WINDOW_END_TESTNET = 1 days;
-
-uint256 constant PAUSE_DEPOSITS_TIME_WINDOW_END_TESTNET = 2 days;
+uint256 constant CHAIN_MIGRATION_TIME_WINDOW_START_TESTNET = 0;
 
 /// @dev Default overhead value in L1 gas for each batch during chain creation.
 uint32 constant DEFAULT_BATCH_OVERHEAD_L1_GAS = 1_000_000;

l1-contracts/contracts/common/Config.sol

@@ -17,7 +17,7 @@ import {UncheckedMath} from "../../../common/libraries/UncheckedMath.sol";
 import {L2ContractHelper} from "../../../common/l2-helpers/L2ContractHelper.sol";
 import {AddressAliasHelper} from "../../../vendor/AddressAliasHelper.sol";
 import {ZKChainBase} from "./ZKChainBase.sol";
-import {MAX_NEW_FACTORY_DEPS, REQUIRED_L2_GAS_PRICE_PER_PUBDATA, SERVICE_TRANSACTION_SENDER, SETTLEMENT_LAYER_RELAY_SENDER, PAUSE_DEPOSITS_TIME_WINDOW_START_TESTNET, PAUSE_DEPOSITS_TIME_WINDOW_END_TESTNET, PAUSE_DEPOSITS_TIME_WINDOW_START_MAINNET, PAUSE_DEPOSITS_TIME_WINDOW_END_MAINNET} from "../../../common/Config.sol";
+import {MAX_NEW_FACTORY_DEPS, REQUIRED_L2_GAS_PRICE_PER_PUBDATA, SERVICE_TRANSACTION_SENDER, SETTLEMENT_LAYER_RELAY_SENDER, PAUSE_DEPOSITS_TIME_WINDOW_START_TESTNET, PAUSE_DEPOSITS_TIME_WINDOW_START_MAINNET} from "../../../common/Config.sol";
 import {L2_INTEROP_CENTER_ADDR} from "../../../common/l2-helpers/L2ContractAddresses.sol";
 
 import {AddressNotZero, GasPerPubdataMismatch, InvalidChainId, MsgValueTooLow, TooManyFactoryDeps, TransactionNotAllowed, ZeroAddress} from "../../../common/L1ContractErrors.sol";
@@ -55,8 +55,6 @@ contract MailboxFacet is ZKChainBase, IMailboxImpl, MessageVerification {
 
     uint256 internal immutable PAUSE_DEPOSITS_TIME_WINDOW_START;
 
-    uint256 internal immutable PAUSE_DEPOSITS_TIME_WINDOW_END;
-
     modifier onlyL1() {
         if (block.chainid != L1_CHAIN_ID) {
             revert NotL1(block.chainid);
@@ -84,9 +82,6 @@ contract MailboxFacet is ZKChainBase, IMailboxImpl, MessageVerification {
         PAUSE_DEPOSITS_TIME_WINDOW_START = _isTestnet
             ? PAUSE_DEPOSITS_TIME_WINDOW_START_TESTNET
             : PAUSE_DEPOSITS_TIME_WINDOW_START_MAINNET;
-        PAUSE_DEPOSITS_TIME_WINDOW_END = _isTestnet
-            ? PAUSE_DEPOSITS_TIME_WINDOW_END_TESTNET
-            : PAUSE_DEPOSITS_TIME_WINDOW_END_MAINNET;
     }
 
     /// @inheritdoc IMailboxImpl
@@ -547,7 +542,7 @@ contract MailboxFacet is ZKChainBase, IMailboxImpl, MessageVerification {
     /// @notice Deposits are paused when a chain migrates to/from GW.
     function depositsPaused() public view returns (bool) {
         return
-            _isInDepositsPausedWindow(PAUSE_DEPOSITS_TIME_WINDOW_START, PAUSE_DEPOSITS_TIME_WINDOW_END) ||
+            _isInDepositsPausedWindow(PAUSE_DEPOSITS_TIME_WINDOW_START) ||
             (block.chainid == L1_CHAIN_ID &&
                 IL1ChainAssetHandler(CHAIN_ASSET_HANDLER).isMigrationInProgress(s.chainId));
     }

l1-contracts/contracts/state-transition/chain-deps/facets/Mailbox.sol

@@ -3,7 +3,7 @@
 pragma solidity 0.8.28;
 
 import {IMigrator} from "../../chain-interfaces/IMigrator.sol";
-import {L1_SETTLEMENT_LAYER_VIRTUAL_ADDRESS, L2DACommitmentScheme, ZKChainCommitment, CHAIN_MIGRATION_TIME_WINDOW_START_TESTNET, CHAIN_MIGRATION_TIME_WINDOW_START_MAINNET, CHAIN_MIGRATION_TIME_WINDOW_END_TESTNET, CHAIN_MIGRATION_TIME_WINDOW_END_MAINNET, PAUSE_DEPOSITS_TIME_WINDOW_START_TESTNET, PAUSE_DEPOSITS_TIME_WINDOW_START_MAINNET, PAUSE_DEPOSITS_TIME_WINDOW_END_TESTNET, PAUSE_DEPOSITS_TIME_WINDOW_END_MAINNET} from "../../../common/Config.sol";
+import {L1_SETTLEMENT_LAYER_VIRTUAL_ADDRESS, L2DACommitmentScheme, ZKChainCommitment, CHAIN_MIGRATION_TIME_WINDOW_START_TESTNET, CHAIN_MIGRATION_TIME_WINDOW_START_MAINNET, PAUSE_DEPOSITS_TIME_WINDOW_START_TESTNET, PAUSE_DEPOSITS_TIME_WINDOW_START_MAINNET} from "../../../common/Config.sol";
 import {PriorityTree} from "../../../state-transition/libraries/PriorityTree.sol";
 import {PriorityQueue} from "../../../state-transition/libraries/PriorityQueue.sol";
 import {IZKChain} from "../../../state-transition/chain-interfaces/IZKChain.sol";
@@ -38,30 +38,18 @@ contract MigratorFacet is ZKChainBase, IMigrator {
     /// @notice The timestamp when chain migration becomes available.
     uint256 internal immutable CHAIN_MIGRATION_TIME_WINDOW_START;
 
-    /// @notice The timestamp when chain migration is no longer available.
-    uint256 internal immutable CHAIN_MIGRATION_TIME_WINDOW_END;
-
     /// @notice The timestamp when deposits start being paused.
     uint256 internal immutable PAUSE_DEPOSITS_TIME_WINDOW_START;
 
-    /// @notice The timestamp when deposits stop being paused.
-    uint256 internal immutable PAUSE_DEPOSITS_TIME_WINDOW_END;
-
     constructor(uint256 _l1ChainId, bool _isTestnet) {
         L1_CHAIN_ID = _l1ChainId;
 
         CHAIN_MIGRATION_TIME_WINDOW_START = _isTestnet
             ? CHAIN_MIGRATION_TIME_WINDOW_START_TESTNET
             : CHAIN_MIGRATION_TIME_WINDOW_START_MAINNET;
-        CHAIN_MIGRATION_TIME_WINDOW_END = _isTestnet
-            ? CHAIN_MIGRATION_TIME_WINDOW_END_TESTNET
-            : CHAIN_MIGRATION_TIME_WINDOW_END_MAINNET;
         PAUSE_DEPOSITS_TIME_WINDOW_START = _isTestnet
             ? PAUSE_DEPOSITS_TIME_WINDOW_START_TESTNET
             : PAUSE_DEPOSITS_TIME_WINDOW_START_MAINNET;
-        PAUSE_DEPOSITS_TIME_WINDOW_END = _isTestnet
-            ? PAUSE_DEPOSITS_TIME_WINDOW_END_TESTNET
-            : PAUSE_DEPOSITS_TIME_WINDOW_END_MAINNET;
     }
 
     modifier onlyL1() {
@@ -87,7 +75,7 @@ contract MigratorFacet is ZKChainBase, IMigrator {
         if (s.priorityModeInfo.canBeActivated) {
             revert NotCompatibleWithPriorityMode();
         }
-        require(s.pausedDepositsTimestamp + PAUSE_DEPOSITS_TIME_WINDOW_END < block.timestamp, DepositsAlreadyPaused());
+        require(s.pausedDepositsTimestamp == 0, DepositsAlreadyPaused());
         uint256 timestamp;
         // Note, if the chain is new (total number of priority transactions is 0) we allow admin to pause the deposits with immediate effect.
         // This is in place to allow for faster migration for newly spawned chains.
@@ -109,11 +97,7 @@ contract MigratorFacet is ZKChainBase, IMigrator {
 
     /// @inheritdoc IMigrator
     function unpauseDeposits() external onlyAdmin onlyL1 {
-        require(
-            s.pausedDepositsTimestamp != 0 &&
-                s.pausedDepositsTimestamp + PAUSE_DEPOSITS_TIME_WINDOW_START <= block.timestamp,
-            DepositsNotPaused()
-        );
+        require(s.pausedDepositsTimestamp != 0, DepositsNotPaused());
         require(
             !IL1ChainAssetHandler(IL1Bridgehub(s.bridgehub).chainAssetHandler()).isMigrationInProgress(s.chainId),
             MigrationInProgress()
@@ -154,8 +138,7 @@ contract MigratorFacet is ZKChainBase, IMigrator {
 
         uint256 timestamp = s.pausedDepositsTimestamp;
         require(
-            timestamp + CHAIN_MIGRATION_TIME_WINDOW_START < block.timestamp &&
-                block.timestamp < timestamp + CHAIN_MIGRATION_TIME_WINDOW_END,
+            timestamp != 0 && timestamp + CHAIN_MIGRATION_TIME_WINDOW_START <= block.timestamp,
             DepositsNotPaused()
         );
 

l1-contracts/contracts/state-transition/chain-deps/facets/Migrator.sol

@@ -181,14 +181,11 @@ contract ZKChainBase is ReentrancyGuard {
         return s.zksyncOS ? ZKSYNC_OS_SYSTEM_UPGRADE_L2_TX_TYPE : SYSTEM_UPGRADE_L2_TX_TYPE;
     }
 
-    /// @notice Returns whether deposits are currently in the paused window.
+    /// @notice Returns whether deposits are currently paused.
     /// @param _windowStart The delay from `pausedDepositsTimestamp` until deposits become paused.
-    /// @param _windowEnd The duration from `pausedDepositsTimestamp` after which deposits are no longer paused.
-    /// @dev We provide 3.5 days window to process all deposits.
-    /// @dev After that, the deposits are not being processed for 3.5 days.
-    function _isInDepositsPausedWindow(uint256 _windowStart, uint256 _windowEnd) internal view returns (bool) {
+    function _isInDepositsPausedWindow(uint256 _windowStart) internal view returns (bool) {
         uint256 timestamp = s.pausedDepositsTimestamp;
-        return timestamp + _windowStart <= block.timestamp && block.timestamp < timestamp + _windowEnd;
+        return timestamp != 0 && timestamp + _windowStart <= block.timestamp;
     }
 
     /// @dev Checks that the batch hash is correct and matches the expected hash.

l1-contracts/contracts/state-transition/chain-deps/facets/ZKChainBase.sol

@@ -41,7 +41,6 @@ import {Call} from "contracts/governance/Common.sol";
 import {ETH_TOKEN_ADDRESS} from "contracts/common/Config.sol";
 import {Create2AndTransfer} from "../utils/deploy/Create2AndTransfer.sol";
 import {ZkChainAddresses, StateTransitionDeployedAddresses, CTMDeployedAddresses, CoreDeployedAddresses} from "../utils/Types.sol";
-import {PAUSE_DEPOSITS_TIME_WINDOW_END_MAINNET} from "contracts/common/Config.sol";
 import {IRegisterZKChain, RegisterZKChainConfig} from "contracts/script-interfaces/IRegisterZKChain.sol";
 import {GetDiamondCutData} from "../utils/GetDiamondCutData.sol";
 
@@ -89,8 +88,8 @@ contract RegisterZKChainScript is Script, IRegisterZKChain {
     function runForTest(address _chainTypeManagerProxy, uint256 _chainChainId) public {
         console.log("Deploying ZKChain");
 
-        // Timestamp needs to be late enough for `pauseDepositsBeforeInitiatingMigration` time checks
-        vm.warp(PAUSE_DEPOSITS_TIME_WINDOW_END_MAINNET + 1);
+        // Avoid block.timestamp == 0 to keep paused-deposits sentinel semantics stable in tests.
+        vm.warp(1);
 
         initializeConfigTest(_chainTypeManagerProxy, _chainChainId);
         runInner(vm.envString("ZK_CHAIN_OUT"));

l1-contracts/deploy-scripts/ctm/RegisterZKChain.s.sol

@@ -2,7 +2,7 @@ force_deployments_data = "0x00"
 gateway_chain_id = 506
 gateway_settlement_fee = 0
 is_zk_sync_os = true
-owner_address = "0xD2BEa76AF8312f0335C8C27703BAfF5aC7Ec8088"
+owner_address = "0x17F713771BC1Da940258ebB56A5D6184372BA681"
 refund_recipient = "0x000000000000000000000000000000000000bEEF"
 support_l2_legacy_shared_bridge_test = false
 testnet_verifier = true

l1-contracts/test/foundry/l1/integration/deploy-scripts/script-config/config-gateway-vote-preparation.toml

@@ -17,7 +17,6 @@ import {BeaconProxy} from "@openzeppelin/contracts-v4/proxy/beacon/BeaconProxy.s
 
 import {IL2NativeTokenVault} from "../../../../../contracts/bridge/ntv/IL2NativeTokenVault.sol";
 import {L2_ASSET_ROUTER_ADDR, L2_ASSET_ROUTER, L2_BASE_TOKEN_SYSTEM_CONTRACT, L2_BASE_TOKEN_SYSTEM_CONTRACT_ADDR, L2_BRIDGEHUB_ADDR, L2_CHAIN_ASSET_HANDLER_ADDR, L2_TO_L1_MESSENGER_SYSTEM_CONTRACT_ADDR, L2_INTEROP_CENTER_ADDR, L2_INTEROP_HANDLER_ADDR, L2_TO_L1_MESSENGER_SYSTEM_CONTRACT, L2_NATIVE_TOKEN_VAULT_ADDR, L2_SYSTEM_CONTEXT_SYSTEM_CONTRACT} from "contracts/common/l2-helpers/L2ContractInterfaces.sol";
-import {PAUSE_DEPOSITS_TIME_WINDOW_END_MAINNET} from "contracts/common/Config.sol";
 import {ETH_TOKEN_ADDRESS} from "contracts/common/Config.sol";
 
 import {AddressAliasHelper} from "contracts/vendor/AddressAliasHelper.sol";
@@ -98,8 +97,8 @@ abstract contract SharedL2ContractDeployer is UtilsCallMockerTest, DeployIntegra
     }
 
     function setUpInner(bool _skip) public virtual {
-        // Timestamp needs to be big enough for `pauseDepositsBeforeInitiatingMigration` time checks
-        vm.warp(PAUSE_DEPOSITS_TIME_WINDOW_END_MAINNET + 1);
+        // Avoid block.timestamp == 0 to keep paused-deposits sentinel semantics stable in tests.
+        vm.warp(1);
 
         if (_skip) {
             vm.startBroadcast();

l1-contracts/test/foundry/l1/integration/l2-tests-abstract/_SharedL2ContractDeployer.sol

@@ -27,7 +27,6 @@ import {ZeroAddress, GenesisBatchHashZero, GenesisBatchCommitmentIncorrect, Gene
 import {ICTMDeploymentTracker} from "contracts/core/ctm-deployment/ICTMDeploymentTracker.sol";
 import {IMessageRootBase} from "contracts/core/message-root/IMessageRoot.sol";
 import {L1MessageRoot} from "contracts/core/message-root/L1MessageRoot.sol";
-import {PAUSE_DEPOSITS_TIME_WINDOW_END_MAINNET} from "contracts/common/Config.sol";
 
 import {L1AssetRouter} from "contracts/bridge/asset-router/L1AssetRouter.sol";
 import {RollupDAManager} from "contracts/state-transition/data-availability/RollupDAManager.sol";
@@ -72,8 +71,8 @@ contract ZKsyncOSChainTypeManagerTest is UtilsCallMockerTest {
     Diamond.FacetCut[] internal facetCuts;
 
     function setUp() public {
-        // Timestamp needs to be late enough for `pauseDepositsBeforeInitiatingMigration` time checks
-        vm.warp(PAUSE_DEPOSITS_TIME_WINDOW_END_MAINNET + 1);
+        // Avoid block.timestamp == 0 to keep paused-deposits sentinel semantics stable in tests.
+        vm.warp(1);
 
         interopCenterAddress = makeAddr("interopCenter");
         governor = makeAddr("governor");