`foundryup` overwrites foundry-zksync with base foundry

[PatrickAlphaC]

Component

Forge

Describe the feature you would like

When I run foundryup to update my foundry edition, it removes my foundry-zksync installation.

Steps to reproduce:

1. Install foundry-zksync (However you like)
2. Run foundryup
3. Try to do any foundry stuff with zksync, you cannot

Additional context

No response

[dutterbutter]

@PatrickAlphaC

Currently this is intentional as the installation uses the same base directory of .foundryup. If we want to avoid overwriting one another while also ensuring devs can execute the desired binary (between upstream and foundry-zksync) we would need to rename the binaries away from forge and cast. We want to keep the namespace the same, but perhaps we can introduce a forge version manager to switch between the two easily enough.

I will leave this open for now, but this is currently intentional.

[hensha256]

@dutterbutter I'm also facing this issue. After running foundryup i rebuilt zksync-foundry to try to get it to re-override forge and it wouldnt do so. I ended up using target/release/forge build --zksync to use this tool. Is this expected? If so I think it would be great to add it to the getting started docs somewhere!

[NouDaimon]

@dutterbutter The installation does not override when we set custom paths and aliases, but this adds a lot of overhead - both in installation and scripts for remote repos.

For engineers using both foundry and foundry-zksync this is cumbersome.

How much of an effort do you reckon it is to alter the base directory to .foundry-zksync and similarly renaming binaries by appending a -zkync?

This would make using the tools in such a way much more explicit.

I'm going to do manually set binary installation directory, and use aliases locally and explicitly define paths in scripts for collaborators but ideally this would be avoided.

[dutterbutter]

Related upstream PR that would close this: foundry-rs/foundry#9505