Skip to content

Commit 76d3b56

Browse files
authored
feat: Remove legacy prover mode from CI (#4391)
## What ❔ Remove legacy prover mode from e2e CI test ## Why ❔ Legacy API mode was removed from code ## Is this a breaking change? - [ ] Yes - [x] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
1 parent 4cf2f67 commit 76d3b56

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

.github/workflows/ci-prover-e2e.yml

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ jobs:
99
fail-fast: false
1010
matrix:
1111
compressor-mode: ["fflonk", "plonk"]
12-
gateway-mode: ["legacy", "prover-cluster"]
1312
env:
1413
RUNNER_COMPOSE_FILE: "docker-compose-gpu-runner-cuda-12-0.yml"
1514
YQ_VERSION: "4.45.1"
@@ -30,7 +29,7 @@ jobs:
3029

3130
- name: Init
3231
run: |
33-
mkdir -p prover_logs_${{matrix.compressor-mode}}_${{matrix.gateway-mode}}
32+
mkdir -p prover_logs_${{matrix.compressor-mode}}
3433
ci_run git config --global --add safe.directory "*"
3534
ci_run chmod -R +x ./bin
3635
@@ -55,13 +54,6 @@ jobs:
5554
echo "Using Web3 HTTP URL: $WEB3_HTTP_URL"
5655
echo "URL=$WEB3_HTTP_URL" >> $GITHUB_ENV
5756
58-
- name: Switch gateway API mode
59-
working-directory: ./chains/proving_chain/configs
60-
if: matrix.gateway-mode == 'prover-cluster'
61-
run: |
62-
sudo yq -e -i '.prover_gateway.api_mode = "PROVER_CLUSTER"' general.yaml
63-
yq '.prover_gateway.api_mode' < general.yaml
64-
6557
- name: Change block_commit_deadline_ms to 60000 to submit txs to batch 1
6658
working-directory: ./chains/proving_chain/configs
6759
run: |
@@ -111,10 +103,10 @@ jobs:
111103
112104
- name: Run prover gateway
113105
run: |
114-
ci_run zkstack prover run --component=gateway --docker=false &>prover_logs_${{matrix.compressor-mode}}_${{matrix.gateway-mode}}/gateway.log &
106+
ci_run zkstack prover run --component=gateway --docker=false &>prover_logs_${{matrix.compressor-mode}}/gateway.log &
115107
- name: Run Prover Job Monitor
116108
run: |
117-
ci_run zkstack prover run --component=prover-job-monitor --docker=false &>prover_logs_${{matrix.compressor-mode}}_${{matrix.gateway-mode}}/prover-job-monitor.log &
109+
ci_run zkstack prover run --component=prover-job-monitor --docker=false &>prover_logs_${{matrix.compressor-mode}}/prover-job-monitor.log &
118110
- name: Wait for batch to be passed through prover gateway
119111
env:
120112
DATABASE_URL: postgres://postgres:notsecurepassword@localhost:5432/zksync_prover_localhost_proving_chain
@@ -126,10 +118,10 @@ jobs:
126118
ci_run ./bin/prover_checkers/batch_availability_checker
127119
- name: Run Witness Generator
128120
run: |
129-
ci_run zkstack prover run --component=witness-generator --round=all-rounds --docker=false &>prover_logs_${{matrix.compressor-mode}}_${{matrix.gateway-mode}}/witness-generator.log &
121+
ci_run zkstack prover run --component=witness-generator --round=all-rounds --docker=false &>prover_logs_${{matrix.compressor-mode}}/witness-generator.log &
130122
- name: Run Circuit Prover
131123
run: |
132-
ci_run zkstack prover run --component=circuit-prover --threads=32 --docker=false &>prover_logs_${{matrix.compressor-mode}}_${{matrix.gateway-mode}}/circuit_prover.log &
124+
ci_run zkstack prover run --component=circuit-prover --threads=32 --docker=false &>prover_logs_${{matrix.compressor-mode}}/circuit_prover.log &
133125
- name: Wait for prover jobs to finish
134126
env:
135127
DATABASE_URL: postgres://postgres:notsecurepassword@localhost:5432/zksync_prover_localhost_proving_chain
@@ -143,7 +135,7 @@ jobs:
143135
- name: Kill prover & start compressor
144136
run: |
145137
sudo ./bin/prover_checkers/kill_prover
146-
ci_run zkstack prover run --component=compressor --docker=false --mode=${{matrix.compressor-mode}} &>prover_logs_${{matrix.compressor-mode}}_${{matrix.gateway-mode}}/compressor.log &
138+
ci_run zkstack prover run --component=compressor --docker=false --mode=${{matrix.compressor-mode}} &>prover_logs_${{matrix.compressor-mode}}/compressor.log &
147139
148140
- name: Wait for batch to be executed on L1
149141
env:
@@ -159,8 +151,8 @@ jobs:
159151
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
160152
if: always()
161153
with:
162-
name: prover_logs_${{matrix.compressor-mode}}_${{matrix.gateway-mode}}
163-
path: prover_logs_${{matrix.compressor-mode}}_${{matrix.gateway-mode}}
154+
name: prover_logs_${{matrix.compressor-mode}}
155+
path: prover_logs_${{matrix.compressor-mode}}
164156

165157
- name: Show sccache logs
166158
if: always()

0 commit comments

Comments
 (0)