Skip to content

Commit 8597c32

Browse files
authored
fix(zkstack): Migration params (#4369)
## What ❔ Pass argumentsto gateway migration non positionaly ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- The `Why` has to be clear to non-Matter Labs entities running their own ZK Chain --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Is this a breaking change? - [ ] Yes - [ ] No ## Operational changes <!-- Any config changes? Any new flags? Any changes to any scripts? --> <!-- Please add anything that non-Matter Labs entities running their own ZK Chain may need to know --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. Signed-off-by: Danil <[email protected]>
1 parent 066b3b1 commit 8597c32

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

zkstack_cli/crates/zkstack/src/commands/chain/gateway/migrate_from_gateway_calldata.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ pub struct MigrateFromGatewayCalldataArgs {
5656

5757
/// Whether to force providing the full migration calldata even if the chain
5858
/// isn't strictly ready for final calls.
59-
#[clap(long, default_missing_value = "false")]
59+
#[clap(long, default_missing_value = "true")]
6060
pub no_cross_check: bool,
6161
}
6262

zkstack_cli/crates/zkstack/src/commands/chain/set_da_validator_pair_calldata.rs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,22 @@ pub struct SetDAValidatorPairCalldataArgs {
3333
pub explicit_settlement_layer_chain_id: Option<u64>,
3434

3535
/// Max L1 gas price to be used for L1->GW transaction (in case the chain is settling on top of ZK Gateway)
36+
#[clap(
37+
long,
38+
help = "Max L1 gas price to be used for L1->GW transaction (in case the chain is settling on top of ZK Gateway)"
39+
)]
3640
pub max_l1_gas_price: Option<u64>,
3741
/// The refund recipient for L1->GW transaction (in case the chain is settling on top of ZK Gateway)
42+
#[clap(
43+
long,
44+
help = "The refund recipient for L1->GW transaction (in case the chain is settling on top of ZK Gateway)"
45+
)]
3846
pub refund_recipient: Option<Address>,
3947
/// The ZK Gateway RPC URL (only used in case the chain is settling on top of ZK Gateway)
48+
#[clap(
49+
long,
50+
help = "The ZK Gateway RPC URL (only used in case the chain is settling on top of ZK Gateway)"
51+
)]
4052
pub gw_rpc_url: Option<String>,
4153
}
4254

0 commit comments

Comments
 (0)