chore: remove outdated TODOs (#42)

## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- The `Why` has to be clear to non-Matter Labs entities running their
own ZK Chain -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Is this a breaking change?
- [ ] Yes
- [ ] No

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted.

Author: antoniolocascio

basic_bootloader/src/bootloader/account_models/contract.rs

@@ -140,9 +140,6 @@ where
 
         *resources = resources_after_main_tx;
 
-        // TODO: when to purge memory?
-        // system.purge_return_memory();
-
         let res = if reverted {
             ExecutionResult::Revert {
                 output: returndata_region,

basic_bootloader/src/bootloader/account_models/eoa.rs

@@ -183,8 +183,6 @@ where
         // panic is not reachable, validated by the structure
         let from = transaction.from.read();
 
-        // TODO: setup metadata for next tx based on out convention and TX fields
-
         let main_calldata = transaction.calldata();
 
         assert!(callstack.len() == 0);

basic_bootloader/src/bootloader/constants.rs

@@ -63,7 +63,6 @@ pub const ERC20_ALLOWANCE_SELECTOR: &[u8] = &[0xdd, 0x62, 0xed, 0x3e];
 pub const ERC20_APPROVE_SELECTOR: &[u8] = &[0x09, 0x5e, 0xa7, 0xb3];
 
 // Value taken from system-contracts, to adjust.
-// TODO: make sure this covers cost for L1 log.
 pub const L1_TX_INTRINSIC_L2_GAS: usize = 11000;
 
 // Includes storing the l1 tx log.

basic_bootloader/src/bootloader/process_transaction.rs

@@ -191,7 +191,6 @@ where
                     }
                     r
                 }
-                // TODO: reconsider for L1 txs!
                 // Out of native is converted to a top-level revert and
                 // gas is exhausted.
                 Err(FatalError::OutOfNativeResources) => {
@@ -398,8 +397,6 @@ where
                 execution_result
             };
 
-        // TODO: notify result?
-
         Ok(execution_result)
     }
 

basic_bootloader/src/bootloader/runner.rs

@@ -568,8 +568,6 @@ where
         // Caller gave away all it's resources into deployment parameters, and in preparation function
         // we will charge for deployment, compute address and potentially increment nonce
 
-        // TODO frame was started here
-
         let ee_type = match &caller_vm {
             Some(vm) => vm.ee_type(),
             None => self.initial_ee_version,
@@ -877,7 +875,6 @@ where
     })
 }
 
-// TODO: all the gas computation in this function seems very EVM-specific.
 // It should be split into EVM and generic part.
 /// Run call preparation, which includes reading the callee parameters
 /// and charging for resources.
@@ -926,7 +923,6 @@ where
 
                 // Positive value cost and stipend
                 let stipend = if !is_delegate && !call_request.nominal_token_value.is_zero() {
-                    // TODO: add native cost
                     let positive_value_cost =
                         S::Resources::from_ergs(Ergs(CALLVALUE * ERGS_PER_GAS));
                     resources.charge(&positive_value_cost)?;

crypto/Cargo.toml

@@ -60,6 +60,7 @@ num-integer = { version = "0.1", default-features = false }
 proptest = "1.0.0"
 hex-literal = "0.4.1"
 ark-test-curves = { version = "0.5.0", features = ["secp256k1", "bls12_381_curve"] }
+rand_core = { version = "0.6.4", features = ["getrandom"] }
 
 # addchain = { git = "https://github.com/VictorArcium/addchain" }
 # num-bigint = { version = "0.3" }
@@ -78,4 +79,3 @@ single_round_with_control = ["blake2s_u32/blake2_with_compression"]
 blake2s_tests = []
 secp256k1-static-context = []
 alloc = []
-

evm_interpreter/src/native_resource_constants.rs

@@ -2,16 +2,11 @@
 pub const ADD_NATIVE_COST: u64 = 140;
 pub const MUL_NATIVE_COST: u64 = 400;
 pub const SUB_NATIVE_COST: u64 = 140;
-//TODO: mean,median are ~500, need more precise computation?
 pub const DIV_NATIVE_COST: u64 = 1500;
-//TODO: mean,median are ~600, need more precise computation?
 pub const SDIV_NATIVE_COST: u64 = 1000;
-//TODO: mean,median are ~600, need more precise computation?
 pub const MOD_NATIVE_COST: u64 = 1300;
 pub const SMOD_NATIVE_COST: u64 = 800;
-//TODO: mean,median are ~600, need more precise computation?
 pub const ADDMOD_NATIVE_COST: u64 = 1700;
-//TODO: mean,median are ~700, need more precise computation?
 pub const MULMOD_NATIVE_COST: u64 = 2300;
 pub const EXP_BASE_NATIVE_COST: u64 = 700;
 pub const EXP_PER_BYTE_NATIVE_COST: u64 = 5_000;