chore: code review comments

remove timeout and console logs

Author: cpb8010

packages/auth-server/composables/useAccountLogin.ts

@@ -36,11 +36,6 @@ export const useAccountLogin = (_chainId: MaybeRef<SupportedChainId>) => {
       });
       return { success: true } as const;
     } catch (error) {
-      // TODO: Guardian recovery not yet available in sdk-4337
-      // Recovery fallback logic commented out
-      // const { checkRecoveryRequest, executeRecovery, getRecovery } = useRecoveryGuardian();
-      // ...recovery logic...
-
       // eslint-disable-next-line no-console
       console.warn("Login failed", error);
       throw new Error("Account not found");

packages/auth-server/composables/useConfigurableAccount.ts

@@ -13,11 +13,7 @@ export const useConfigurableAccount = () => {
 
     // Get current block to calculate safe fromBlock (avoid RPC block range limits)
     // Add timeout to prevent hanging RPC calls (5s should be sufficient)
-    const currentBlockPromise = publicClient.getBlockNumber();
-    const blockTimeoutPromise = new Promise<never>((_, reject) =>
-      setTimeout(() => reject(new Error("Timeout getting block number after 5 seconds")), 5000),
-    );
-    const currentBlock = await Promise.race([currentBlockPromise, blockTimeoutPromise]);
+    const currentBlock = await publicClient.getBlockNumber();
 
     // Use 100k block range to ensure we catch all events (tests pass with this value)
     const fromBlock = currentBlock > 100000n ? currentBlock - 100000n : 0n;
@@ -27,7 +23,7 @@ export const useConfigurableAccount = () => {
     // but works for now.
 
     // Add timeout to event queries to prevent hanging (10s to handle multiple accounts in test environments)
-    const eventsPromise = Promise.all([
+    const [events, removedEvents] = await Promise.all([
       publicClient.getContractEvents({
         address: webauthnValidatorAddress,
         abi: WebAuthnValidatorAbi,
@@ -50,8 +46,6 @@ export const useConfigurableAccount = () => {
       }),
     ]);
 
-    const [events, removedEvents] = await Promise.race([eventsPromise]);
-
     if (!events || events.length === 0) {
       throw new Error("Account not found");
     }

packages/auth-server/pages/recovery/guardian/(actions)/confirm-recovery.vue

@@ -179,16 +179,11 @@ const recoveryCompleted = computedAsync(async () => {
   console.log("recoveryCompleted evaluating, trigger:", _triggerValue);
 
   if (!recoveryParams.value?.accountAddress || !recoveryParams.value?.credentialId || !recoveryParams.value?.credentialPublicKey) {
-    // eslint-disable-next-line no-console
-    console.log("recoveryCompleted: Missing params");
     return false;
   }
 
   const result = await getRecovery(recoveryParams.value.accountAddress);
 
-  // eslint-disable-next-line no-console
-  console.log("getRecovery result:", result);
-
   // The smart contract stores keccak256(data) where data is the encoded recovery payload
   // We need to reconstruct the same data structure that was passed to initializeRecovery
   const parsedPublicKey = JSON.parse(recoveryParams.value.credentialPublicKey);
@@ -209,16 +204,8 @@ const recoveryCompleted = computedAsync(async () => {
 
   const expectedHashedData = keccak256(recoveryData);
 
-  // eslint-disable-next-line no-console
-  console.log("Expected hashedData:", expectedHashedData);
-  // eslint-disable-next-line no-console
-  console.log("Actual hashedData:", result?.hashedData);
-
   const isComplete = result?.hashedData === expectedHashedData;
 
-  // eslint-disable-next-line no-console
-  console.log("Recovery complete:", isComplete);
-
   return isComplete;
 });
 
@@ -284,9 +271,6 @@ const handleConfirmRecovery = async () => {
     const maxRetries = 10;
     const retryDelay = 1000; // 1 second between checks
 
-    // eslint-disable-next-line no-console
-    console.log("Starting recovery completion polling...");
-
     for (let i = 0; i < maxRetries; i++) {
       await new Promise((resolve) => setTimeout(resolve, retryDelay));
       recoveryCheckTrigger.value++;
@@ -304,9 +288,6 @@ const handleConfirmRecovery = async () => {
         break;
       }
     }
-
-    // eslint-disable-next-line no-console
-    console.log("Finished polling. Final recoveryCompleted:", recoveryCompleted.value);
   } catch (err) {
     confirmGuardianErrorMessage.value = "An error occurred while confirming the guardian. Please try again.";
     // eslint-disable-next-line no-console