fix: address code review comments

bigInt to number breaks types

Author: cpb8010

packages/sdk-4337/src/client/session/utils.ts

@@ -146,13 +146,14 @@ export function getSessionHash(spec: SessionSpec): Hex {
   const createSessionFunction = SessionKeyValidatorAbi.find(
     (x) => x.type === "function" && x.name === "createSession",
   );
-  if (!createSessionFunction) throw new Error("createSession function not found in ABI");
+  if (!createSessionFunction) throw new Error("createSession function not found in SessionKeyValidator ABI");
 
   const sessionSpecParam = createSessionFunction.inputs.find((x) => x.name === "sessionSpec");
-  if (!sessionSpecParam) throw new Error("sessionSpec param not found in createSession ABI");
+  if (!sessionSpecParam) throw new Error("sessionSpec parameter not found in createSession function inputs");
 
   const encoded = encodeAbiParameters(
     [sessionSpecParam],
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     [spec as any],
   );
   return keccak256(encoded);

packages/sdk-platforms/rust/zksync-sso-erc4337/crates/zksync-sso-erc4337-core/src/erc4337/account/modular_smart_account/session/create.rs

@@ -117,12 +117,30 @@ mod tests {
         },
     };
     use alloy::{
-        primitives::{U256, Uint, address, bytes, fixed_bytes, keccak256},
+        primitives::{Address, Bytes, U256, Uint, address, bytes, fixed_bytes, keccak256},
         signers::{SignerSync, local::PrivateKeySigner},
         sol_types::SolValue,
     };
     use std::str::FromStr;
 
+    fn generate_session_proof(
+        session_spec: &SessionSpec,
+        account_address: Address,
+        signer_private_key: &str,
+    ) -> eyre::Result<Bytes> {
+        let session_lib_spec: crate::erc4337::account::modular_smart_account::session::contract::SessionLib::SessionSpec =
+            session_spec.clone().into();
+        let session_hash = keccak256(session_lib_spec.abi_encode());
+        let digest = keccak256((session_hash, account_address).abi_encode());
+
+        let session_signer_instance =
+            PrivateKeySigner::from_str(signer_private_key)?;
+        Ok(session_signer_instance
+            .sign_hash_sync(&digest)?
+            .as_bytes()
+            .into())
+    }
+
     #[tokio::test]
     async fn test_create_session() -> eyre::Result<()> {
         let (
@@ -250,16 +268,11 @@ mod tests {
             };
 
             // Calculate proof
-            let session_lib_spec: crate::erc4337::account::modular_smart_account::session::contract::SessionLib::SessionSpec = session_spec.clone().into();
-            let session_hash = keccak256(session_lib_spec.abi_encode());
-            let digest = keccak256((session_hash, address).abi_encode());
-
-            let session_signer_instance =
-                PrivateKeySigner::from_str(&signer_private_key)?;
-            let proof = session_signer_instance
-                .sign_hash_sync(&digest)?
-                .as_bytes()
-                .into();
+            let proof = generate_session_proof(
+                &session_spec,
+                address,
+                &signer_private_key,
+            )?;
 
             create_session(CreateSessionParams {
                 account_address: address,
@@ -410,16 +423,11 @@ mod tests {
             };
 
             // Calculate proof
-            let session_lib_spec: crate::erc4337::account::modular_smart_account::session::contract::SessionLib::SessionSpec = session_spec.clone().into();
-            let session_hash = keccak256(session_lib_spec.abi_encode());
-            let digest = keccak256((session_hash, address).abi_encode());
-
-            let session_signer_instance =
-                PrivateKeySigner::from_str(&signer_private_key)?;
-            let proof = session_signer_instance
-                .sign_hash_sync(&digest)?
-                .as_bytes()
-                .into();
+            let proof = generate_session_proof(
+                &session_spec,
+                address,
+                &signer_private_key,
+            )?;
 
             create_session(CreateSessionParams {
                 account_address: address,