featfeat(swift sdk): addressing comments

Author: jackpooleyml

packages/sdk-platforms/rust/zksync-sso/TODO.md

@@ -0,0 +1,7 @@
+# TODOs
+
+[ ] Move `fund` method to seperate module to make 
+    it clear this is not indended for production use
+[ ] Use paymaster for deployement rather than rich wallet
+[ ] Consider using the `log` crate for debug logging
+[ ] Change passkey attestation to `direct`

packages/sdk-platforms/rust/zksync-sso/crates/sdk/src/api/account/balance.rs

@@ -1,5 +1,6 @@
-use crate::{config::Config, utils::alloy::conveniences::get_provider};
+use crate::config::Config;
 use alloy::{primitives::Address, providers::Provider};
+use alloy_zksync::provider::zksync_provider;
 use money::{Money, MoneyFormatter};
 
 #[derive(Debug)]
@@ -13,11 +14,12 @@ pub async fn get_balance(
 ) -> eyre::Result<GetAccountBalanceResult> {
     println!("XDB get_balance - address: {:?}", address);
 
-    let provider = get_provider(config)?;
+    let provider = zksync_provider().on_http(config.node_url.clone());
+
     let balance_uint = provider.get_balance(address).await?;
 
     let money = Money::eth(balance_uint);
-    
+
     let formatter = MoneyFormatter::default().with_display_decimals(6);
     let balance = formatter.format(&money);
 

packages/sdk-platforms/rust/zksync-sso/crates/sdk/src/api/account/fund.rs

@@ -9,6 +9,7 @@ use alloy_zksync::network::transaction_request::TransactionRequest;
 use money::Money;
 use rand::Rng;
 
+// TODO: move this to testing module
 pub async fn fund_account(
     address: Address,
     amount: U256,

packages/sdk-platforms/rust/zksync-sso/crates/sdk/src/client/passkey/actions/deploy/account_factory/create2_address.rs

@@ -1,5 +1,6 @@
 use alloy::primitives::{keccak256, Address, Bytes, FixedBytes};
 
+// TODO: consider uptreaming this to the `alloy-zksync` crate
 pub fn create2_address(
     account_factory_address: Address,
     smart_account_bytecode_hash: FixedBytes<32>,

packages/sdk-platforms/rust/zksync-sso/crates/sdk/src/utils/alloy.rs

@@ -1,7 +1,6 @@
 use alloy::primitives::Address;
 use eyre::eyre;
 
-pub mod conveniences;
 pub mod extensions;
 pub mod null_signer;
 pub mod passkey_raw_signer;
@@ -21,7 +20,7 @@ mod tests {
 
         let invalid = "0x1234";
         assert!(parse_address(invalid).is_err());
-        
+
         let invalid = "0xghijk";
         assert!(parse_address(invalid).is_err());
     }

packages/sdk-platforms/rust/zksync-sso/crates/sdk/src/utils/alloy/conveniences.rs

@@ -28,13 +28,7 @@ pub fn encode_passkey_module_parameters(
         expectedOrigin: passkey.expected_origin,
     };
 
-    let mut params_bytes = PasskeyParams::abi_encode(&params);
-    if params_bytes.starts_with(&[
-        0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
-        0, 0, 0, 0, 0, 0, 0, 32,
-    ]) {
-        params_bytes = params_bytes[32..].to_vec();
-    }
+    let params_bytes = PasskeyParams::abi_encode_params(&params);
 
     Ok(params_bytes.into())
 }
@@ -57,13 +51,7 @@ pub fn encode_module_data(module_data: ModuleData) -> Result<Bytes> {
         parameters: module_data.parameters,
     };
 
-    let mut encoded = ModuleParams::abi_encode(&params);
-    if encoded.starts_with(&[
-        0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
-        0, 0, 0, 0, 0, 0, 0, 32,
-    ]) {
-        encoded = encoded[32..].to_vec();
-    }
+    let encoded = ModuleParams::abi_encode_params(&params);
 
     Ok(encoded.into())
 }