feat!: Mailbox function deprecation (#550)

# What ❔

- Contract: 
- Deprecated the usage of
`Mailbox.finalizeEthWithdrawal`/`L1ERC20Bridge.finalizeWithfrawal` in
favor of `L1Nullifier.finalizeDeposit`
- Changed the usage of env variables for a constructor to set the
address of L1AssetRouter
- Server: retrieved added the L2 chain Id into the flow as it is now
required by the contract.
- Added contract-specific GH workflow `contracts-ci.yml`
- Updated some dependencies to successfully compile the contract

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `cargo fmt`.

Author: jcsec-security

.github/workflows/build_and_publish.yml

@@ -11,7 +11,9 @@ jobs:
     runs-on: [matterlabs-ci-runner]
 
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      - name: Checkout code
+        uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+
       - name: Set up Docker Build
         uses: docker/setup-buildx-action@v3
 

.github/workflows/cargo-deny.yml

@@ -2,8 +2,7 @@ name: Cargo Deny
 
 on:
   push:
-    branches:
-      - main
+    branches: [ main ]
   pull_request:
   merge_group:
 

.github/workflows/check-spelling.yml

@@ -2,8 +2,7 @@ name: Check Spelling
 
 on:
   push:
-    branches:
-      - main
+    branches: [ main ]
   pull_request:
   merge_group:
 

.github/workflows/ci.yml

@@ -2,9 +2,7 @@ name: CI
 
 on:
   push:
-    branches:
-      - main
-
+    branches: [ main ]
   pull_request:
   merge_group:
 
@@ -19,19 +17,22 @@ jobs:
   build_and_test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      - name: Checkout
+        uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
 
       - name: Install stable toolchain
         uses: actions-rs/toolchain@v1
         with:
           toolchain: stable
           override: true
 
+      - name: Install Foundry (for anvil)
+        uses: foundry-rs/foundry-toolchain@v1
+        with:
+          version: nightly
+
       - name: Rust Cache
         uses: Swatinem/rust-cache@v2
-
-      - name: Install Foundry
-        uses: foundry-rs/foundry-toolchain@v1
 
       - name: Build project
         run: |

.github/workflows/contract-ci.yml

@@ -0,0 +1,94 @@
+name: Contracts CI
+permissions:
+  contents: read
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+  merge_group:
+
+env: 
+  CARGO_TERM_COLOR: always
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Use Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: npm
+          cache-dependency-path: package-lock.json
+
+      - name: Install dependencies
+        run: npm ci
+    
+      - name: Compile (Hardhat)
+        run: npm run contracts:build
+
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Use Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: npm
+          cache-dependency-path: package-lock.json
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: solhint (contracts only)
+        run: npx solhint --noPoster "contracts/**/*.sol"
+
+      - name: prettier (contracts only)
+        run: npx prettier --plugin=prettier-plugin-solidity --check "contracts/**/*.sol"
+
+  #
+  # Missing test job!
+  #
+
+  slither:
+    needs: [build]
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Use Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: npm
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Setup Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+
+      - name: Install Slither
+        run: pip install slither-analyzer
+
+      - name: Run Slither (compiling through Hardhat)
+        run: |
+          slither --config slither.config.json . --compile-force-framework hardhat \
+            --filter-paths "node_modules|artifacts|cache"

.github/workflows/secrets_scanner.yaml

@@ -1,15 +1,21 @@
 name: Leaked Secrets Scan
+
 on:
+  push:
+    branches: [ main ]
   pull_request:
   merge_group:
+
 jobs:
   TruffleHog:
     runs-on: ubuntu-latest
+
     steps:
       - name: Checkout code
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
         with:
           fetch-depth: 0
+
       - name: TruffleHog OSS
         uses: trufflesecurity/trufflehog@80e8a67c2d863ee8f6563b4e2806c93b8bfd96ea
         with:

.solhint.json

@@ -0,0 +1,36 @@
+{
+  "extends": "solhint:recommended",
+  "rules": {
+    "avoid-call-value": "error",
+    "avoid-low-level-calls": "off",
+    "avoid-sha3": "error",
+    "avoid-tx-origin": "off",
+    "check-send-result": "error",
+    "compiler-version": ["error", "^0.8.0"],
+    "const-name-snakecase": "off",
+    "contract-name-capwords": "off",
+    "explicit-types": "error",
+    "func-name-mixedcase": "off",
+    "func-named-parameters": ["error", 4],
+    "func-visibility": ["error", { "ignoreConstructors": true }],
+    "imports-on-top": "error",
+    "max-states-count": "off",
+    "modifier-name-mixedcase": "error",
+    "named-parameters-mapping": "off",
+    "no-complex-fallback": "off",
+    "no-console": "error",
+    "no-empty-blocks": "off",
+    "no-global-import": "error",
+    "no-inline-assembly": "off",
+    "no-unused-import": "error",
+    "no-unused-vars": "error",
+    "not-rely-on-time": "off",
+    "quotes": "error",
+    "reason-string": "error",
+    "reentrancy": "error",
+    "state-visibility": "error",
+    "use-forbidden-name": "error",
+    "var-name-mixedcase": "off",
+    "visibility-modifier-order": "error"
+  }
+}