Support Matrix authenticated media

[poVoq]

Matrix now requires to authenticate before downloading files such as shared pictures.

There are two different open PRs to fix this in the upstream repo.

1. Matrix: respect MSC3916, send bearer token when downloading images (#2184 #2205) 42wim/matterbridge#2225
2. Implement Matrix Authenticated Media for Servers 42wim/matterbridge#2227

As I am not so deeply into Matrix, I am not entirely sure what the difference between these is and which one would make more sense to add.

There is also a related PR from the same author as 2. that seems related enough to also merge:

42wim#2228

@c-holtermann & @readthisusernamebackwards comments and PRs welcome.

[Wohlstand]

I probably already picked up some of these changes on my branch, maybe I'll make PR too?

[Wohlstand]

Originally these changes taken from @bibanon here, my fork is based on this origin, and then I implemented my own (unrelated) fixes.

[selfhoster1312]

Apparently the way to do things with matrix now is with Authorization header, as in 42wim#2225

Using a query param access_token as in 42wim#2227 is also deprecated and will be removed sooner or later. Quoting MSC3916:

Clients SHOULD NOT use the deprecated ?access_token query string authentication mechanism. The method is pending removal and is generally unsafe. See those MSCs for further details.

[selfhoster1312]

I'm also noting the matrix lib we use is forked from https://github.com/matrix-org/gomatrix which did not receive updates in the past years… It looks like mautrix is the maintained fork: https://github.com/mautrix/go

[c-holtermann]

Apparently the way to do things with matrix now is with Authorization header, as in 42wim#2225

Using a query param access_token as in 42wim#2227 is also deprecated and will be removed sooner or later. Quoting MSC3916:

Clients SHOULD NOT use the deprecated ?access_token query string authentication mechanism. The method is pending removal and is generally unsafe. See those MSCs for further details.

I am running my own fork with my suggested changes just to make it work for me and have shared them. I haven't looked into this since then. It seems that the api has changed even further as selfhoster1312 writes and makes additional changes necessary. That's all I understand for the moment.

Nice to see that there is interaction and activity on this project.

[poVoq]

Ok looks like we better go for option 1 then. There are people in that PR confirming that it works as expected.

I agree that the Matrix library needs replacement. There is a somewhat recent PR that switches it with Mautrix here. Using the Mautrix library would also allow creating proper puppets via the appservice API.

[poVoq]

Ok testing the current master without a fix definitely shows that it isn't working currently. Sharing an image on the Matrix side only results in the name of the image file shared on the IRC side, but with the following error in the Matterbridge logs:

level=error msg="download failed: &errors.errorString{s:"download https://matrix.f-hub.org/_matrix/media/v1/download/matrix.f-hub.org/XJYwPcvdVWUrtnGumrdOQamD failed &fmt.wrapError{msg:\"HTTP server responded non-OK code: https://matrix.f-hub.org/_matrix/media/v1/download/matrix.f-hub.org/XJYwPcvdVWUrtnGumrdOQamD returned code 404\", err:(*errors.errorString)(0x21f4b20)}"}" prefix=matrix

[poVoq]

ok, testing this with patch merged in: #58 and media-proxy enabled, results in a functional link on the IRC side, so that should be good to merge.

[poVoq]

This is done now. Thanks to all involved.