Bug: Leaving a team doesn't remove user's board memberships

[harshilsharma63]

Steps to reproduce the behavior

1. Create a team (Team A).
2. Create some boards in Team A.
3. Try searching for those boards, and notice they do come up in search results, which is all good.
4. Not leave this team (team A).
5. Go back to boards, and try searching for those boards you created in Team A. Notice that they still show up in search results. You can, however, not join them.

Expected behavior

Boards corresponding to a team a user is not part of should not show up in search results.

Edition and Platform

• Edition: Mattermost Boards (plugin)
• Version: 0.16

[mgdelacroix]

This PR will fix boards for teams you're not a member of appearing on search results: #2971

I think tho we should discuss if we should add a plugin hook for users being removed from teams and triggering board membership removal, as being readded to the team will preserve board memberships

[harshilsharma63]

Thanks for sharing that PR!

being readded to the team will preserve board memberships

how would we preserve board memberships if we delete them on leaving a team?

[mgdelacroix]

I meant that being readded to the board now, if we don't add that hook, will preserve board memberships. Right now, if a user leaves a team on channels, we don't do anything on our side to delete their state on boards

[wuwinson]

@harshilsharma63 Are these public boards in step 5? If so, user should still be able to search them, but not being able to join them is an issue. If they're private boards, then yeah, they should not appear in the search results and that would be a more serious problem.

[wuwinson]

@wuwinson to investigate Channels behavior when user leaves and rejoins team.

#2971 can be considered the Sev/1, this one is TBD.