Skip to content

Fix tooltip cutoff #4100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

redhoyasa
Copy link
Contributor

Summary

Fix the kanban card tooltip that cutting off. I consider the both tooltip with short text and long text.

Before After
Screen Shot 2021-10-23 at 13 14 38 Screen Shot 2021-10-23 at 13 15 58

Ticket Link

Fix #3246.

@mattermod
Copy link
Contributor

Hello @redhoyasa,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@kamre
Copy link
Contributor

kamre commented Oct 30, 2022

Hi @redhoyasa, it seems that proposed fix changes tooltip for all cards, even in the second column of kanban board:

before applying the fix it looks like this:

@redhoyasa
Copy link
Contributor Author

@kamre thanks for the feedback. I try to make some changes. Does it look good to you?

Screenshot 2022-10-31 at 4 33 42 PM

@kamre
Copy link
Contributor

kamre commented Oct 31, 2022

@redhoyasa this definitely looks better.

@asaadmahmood what do you think about such changes to tooltip?

@asaadmahmood
Copy link
Contributor

@kamre @redhoyasa I think those look good, but it wouldn't make sense to always have the tip on the left. If we can make the tip position dynamic, like center, left, or right depending on the space available, that would be much better.

Otherwise, I don't want to change all tooltips to have the tip on the bottom left.

@redhoyasa
Copy link
Contributor Author

@asaadmahmood @kamre that makes sense. Depending on available space could work but I'd like to propose something like this:

  1. For card within the left most list, the position would be on left
  2. For card within the right most list, the position would be on right
  3. Otherwise, the tooltip will be on the center

I think that way is easier to reason, what do you think?

@asaadmahmood
Copy link
Contributor

@redhoyasa That can be done though important to note that it's not always about the left most or right most list.
It can be any list, as we allow scrolling.

So imagine you have 12 lists, and you hoirzontally scroll, so now the 3rd or 4th list can be the first list (visually speaking).

So even if we do it, it should focus more on the list position visually rather than its order.

@sbishel sbishel requested a review from asaadmahmood November 2, 2022 20:46
@sbishel sbishel added the 1: UX Review Requires review by ux label Nov 2, 2022
@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Copy link
Contributor

@asaadmahmood asaadmahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: kanban card property tooltip is cut off
5 participants