-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix tooltip cutoff #4100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix tooltip cutoff #4100
Conversation
Hello @redhoyasa, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
Hi @redhoyasa, it seems that proposed fix changes tooltip for all cards, even in the second column of kanban board: |
@kamre thanks for the feedback. I try to make some changes. Does it look good to you? |
@redhoyasa this definitely looks better. @asaadmahmood what do you think about such changes to tooltip? |
@kamre @redhoyasa I think those look good, but it wouldn't make sense to always have the tip on the left. If we can make the tip position dynamic, like center, left, or right depending on the space available, that would be much better. Otherwise, I don't want to change all tooltips to have the tip on the bottom left. |
@asaadmahmood @kamre that makes sense. Depending on available space could work but I'd like to propose something like this:
I think that way is easier to reason, what do you think? |
@redhoyasa That can be done though important to note that it's not always about the left most or right most list. So imagine you have 12 lists, and you hoirzontally scroll, so now the 3rd or 4th list can be the first list (visually speaking). So even if we do it, it should focus more on the list position visually rather than its order. |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale
Summary
Fix the kanban card tooltip that cutting off. I consider the both tooltip with short text and long text.
Ticket Link
Fix #3246.