test(e2e): stabilize Zephyr specs and enable public links in CI.

Fix flaky help menu refresh, harden media preview and window position tests, and enable FileSettings.EnablePublicLink on E2E servers before Playwright runs.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: yasserfaraazkhan

.github/workflows/e2e-functional-template.yml

@@ -287,6 +287,10 @@ jobs:
           npm ci
           cd e2e && npm ci
 
+      - name: e2e/enable-public-links
+        if: env.MM_TEST_SERVER_URL != ''
+        run: node e2e/scripts/enable-public-links.mjs
+
       - name: e2e/suppress-macos-dialogs
         if: runner.os == 'macOS'
         run: |

e2e/helpers/helpMenuLinks.ts

@@ -33,7 +33,12 @@ export async function patchHelpMenuRemoteInfo(
         }
         refs.ServerManager.updateRemoteInfo(serverId, nextRemoteInfo);
 
-        ipcMain.emit('emit-configuration', null);
+        const configData = refs.Config?.data ?? refs.Config?.combinedData;
+        if (!configData) {
+            throw new Error('Config.data is not available for menu refresh');
+        }
+
+        ipcMain.emit('emit-configuration', null, configData);
     }, patch);
 }
 

e2e/helpers/server_api/publicLinks.ts

@@ -0,0 +1,51 @@
+// Copyright (c) 2016-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+import {apiLogin, apiRequest} from './client';
+import {getTestServerCredentials} from './credentials';
+
+type ServerConfig = {
+    FileSettings?: {
+        EnablePublicLink?: boolean;
+    };
+    ServiceSettings?: {
+        SiteURL?: string;
+    };
+};
+
+export async function isPublicLinkEnabled(credentials = getTestServerCredentials()): Promise<boolean> {
+    const token = await apiLogin(credentials.baseUrl, credentials.username, credentials.password);
+    const config = await apiRequest<ServerConfig>(credentials.baseUrl, token, '/api/v4/config');
+    return config.FileSettings?.EnablePublicLink === true;
+}
+
+export async function enablePublicLinks(credentials = getTestServerCredentials()): Promise<boolean> {
+    const token = await apiLogin(credentials.baseUrl, credentials.username, credentials.password);
+    const config = await apiRequest<ServerConfig>(credentials.baseUrl, token, '/api/v4/config');
+
+    if (config.FileSettings?.EnablePublicLink === true) {
+        return false;
+    }
+
+    const siteURL = config.ServiceSettings?.SiteURL ?? credentials.baseUrl;
+    await apiRequest(credentials.baseUrl, token, '/api/v4/config', {
+        method: 'PUT',
+        body: JSON.stringify({
+            ...config,
+            ServiceSettings: {...config.ServiceSettings, SiteURL: siteURL},
+            FileSettings: {...config.FileSettings, EnablePublicLink: true},
+        }),
+    });
+
+    return true;
+}
+
+export async function getFilePublicLink(fileId: string, credentials = getTestServerCredentials()): Promise<string> {
+    const token = await apiLogin(credentials.baseUrl, credentials.username, credentials.password);
+    const response = await apiRequest<{link: string}>(
+        credentials.baseUrl,
+        token,
+        `/api/v4/files/${fileId}/link`,
+    );
+    return response.link;
+}

e2e/scripts/enable-public-links.mjs

@@ -0,0 +1,81 @@
+// Copyright (c) 2016-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+const baseUrl = (process.env.MM_TEST_SERVER_URL ?? '').replace(/\/$/, '');
+const username = process.env.MM_TEST_USER_NAME;
+const password = process.env.MM_TEST_PASSWORD;
+
+if (!baseUrl || !username || !password) {
+    console.error('MM_TEST_SERVER_URL, MM_TEST_USER_NAME, and MM_TEST_PASSWORD are required');
+    process.exit(1);
+}
+
+async function apiLogin() {
+    const response = await fetch(`${baseUrl}/api/v4/users/login`, {
+        method: 'POST',
+        headers: {'Content-Type': 'application/json'},
+        body: JSON.stringify({login_id: username, password}),
+    });
+    if (!response.ok) {
+        throw new Error(`Login failed: ${response.status} ${await response.text()}`);
+    }
+
+    const token = response.headers.get('Token') ?? response.headers.get('token');
+    if (token) {
+        return token;
+    }
+
+    const body = await response.json();
+    if (body.token) {
+        return body.token;
+    }
+
+    throw new Error('Login did not return a session token');
+}
+
+async function apiRequest(token, path, init = {}) {
+    const response = await fetch(`${baseUrl}${path}`, {
+        ...init,
+        headers: {
+            Authorization: `Bearer ${token}`,
+            'Content-Type': 'application/json',
+            ...init.headers,
+        },
+    });
+    if (!response.ok) {
+        throw new Error(`${init.method ?? 'GET'} ${path} failed: ${response.status} ${await response.text()}`);
+    }
+    return response.json();
+}
+
+async function main() {
+    const token = await apiLogin();
+    const config = await apiRequest(token, '/api/v4/config');
+
+    if (config.FileSettings?.EnablePublicLink === true) {
+        console.log('Public links already enabled on the E2E server');
+        return;
+    }
+
+    const siteURL = config.ServiceSettings?.SiteURL ?? baseUrl;
+    await apiRequest(token, '/api/v4/config', {
+        method: 'PUT',
+        body: JSON.stringify({
+            ...config,
+            ServiceSettings: {...config.ServiceSettings, SiteURL: siteURL},
+            FileSettings: {...config.FileSettings, EnablePublicLink: true},
+        }),
+    });
+
+    const updated = await apiRequest(token, '/api/v4/config');
+    if (updated.FileSettings?.EnablePublicLink !== true) {
+        throw new Error('Failed to enable public links on the E2E server');
+    }
+
+    console.log('Enabled public links on the E2E server');
+}
+
+main().catch((error) => {
+    console.error(error);
+    process.exit(1);
+});