[MM-69551] Update desktop onboarding for DISC audience#3879
[MM-69551] Update desktop onboarding for DISC audience#3879matthewbirtch wants to merge 7 commits into
Conversation
Refresh welcome screen messaging and integrations illustration, align the server connection screen with updated Figma copy, and adjust related layout styles and E2E expectations. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@matthewbirtch: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsI understand the commands that are listed here |
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdates UI copy, layout, and illustration for the WelcomeScreen and ConfigureServer screens. Welcome slide text and button casing change, ConfigureServer header copy and responsive layout are revised, the ToolsImage SVG is replaced, and matching e2e assertions are updated. ChangesWelcome Screen & ConfigureServer UI Refresh
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/renderer/components/ConfigureServer/ConfigureServer.scss`:
- Around line 208-210: The ConfigureServer styles contain an empty selector
block for .ConfigureServer__message and .ConfigureServer__card, which triggers
the block-no-empty lint rule. Remove this empty rule from ConfigureServer.scss,
or add real declarations if these selectors are meant to style something, so
Stylelint passes.
In `@src/renderer/components/ConfigureServer/ConfigureServer.tsx`:
- Line 6: The fallback header copy in ConfigureServer should use
FormattedMessage instead of calling formatMessage directly. Update the default
title/subtitle rendering in ConfigureServer so the branch that supplies the
fallback header content uses FormattedMessage, while keeping messageTitle and
messageSubtitle as raw props. Refer to ConfigureServer and its header-copy
rendering logic to swap the i18n implementation without changing the existing
prop behavior.
In `@src/renderer/components/Images/tools.tsx`:
- Around line 7-16: This SVG JSX block in tools.tsx needs formatting fixes to
satisfy CI prop-wrapping and indentation rules. Reformat the JSX inside the SVG
markup, keeping the same structure but aligning attributes and nested elements
consistently, especially around the clipPath group and the surrounding
rect/path/circle elements. Use the existing component/block in Images/tools.tsx
as the target and run the project formatter so build-linux and build-mac-no-dmg
pass again.
In `@src/renderer/components/WelcomeScreen/WelcomeScreen.tsx`:
- Line 6: The welcome screen text is still being rendered through
`formatMessage(...)` instead of the message component. In
`WelcomeScreen`/`WelcomeScreen.tsx`, update the slide titles, subtitles, and the
“Get started” label to use `FormattedMessage` for rendering visible content, and
keep `useIntl().formatMessage` only for non-rendered raw attributes or
placeholders if needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 527313ad-be54-46c7-9499-da395829e75d
📒 Files selected for processing (10)
e2e/specs/policy/policy.test.tse2e/specs/startup/app.test.tse2e/specs/startup/welcome_screen_modal.test.tsi18n/en.jsonsrc/renderer/components/Carousel/Carousel.scsssrc/renderer/components/ConfigureServer/ConfigureServer.scsssrc/renderer/components/ConfigureServer/ConfigureServer.tsxsrc/renderer/components/Images/tools.tsxsrc/renderer/components/WelcomeScreen/WelcomeScreen.tsxsrc/renderer/components/WelcomeScreen/WelcomeScreenSlide.scss
Reformat the integrations SVG to satisfy jsx-max-props-per-line and indent rules, and drop empty ConfigureServer media-query blocks. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
Restore react-intl FormattedMessage for default title and subtitle while keeping messageTitle and messageSubtitle as raw prop overrides. Co-authored-by: Cursor <cursoragent@cursor.com>
Render slide titles, subtitles, and the Get started button with FormattedMessage instead of formatMessage. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@coderabbity review |
mm-cloud-bot
added
release-note-none
release-note
and removed
do-not-merge/release-note-label-needed
release-note-none
labels
esethna
left a comment
esethna
left a comment
There was a problem hiding this comment.
Thanks @matthewbirtch, left some non-blocking comments/suggestions on the mobile PR: mattermost/mattermost-mobile#9901 (review)
Refine the welcome subtitle and integrations slide messaging per leadership review feedback. Co-authored-by: Cursor <cursoragent@cursor.com>
matthewbirtch
added
2: Dev Review
Simplify the Configure Server header copy per leadership feedback. Co-authored-by: Cursor <cursoragent@cursor.com>
Explain that a server is the team's communication hub accessed via a unique URL. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Looks great. 👍 |
|
@lindalumitchell when you have some time could I ask you to do a quick QA pass on this? It should be pretty straightforward, but let me know if you have any questions. |
5 participants
Summary
Test plan
e2e/specs/startup/welcome_screen_modal.test.tsand related startup/policy E2E specsMade with Cursor
Change Impact: Low 🟢
Regression Risk: Low—updates are limited to desktop onboarding UI (welcome/server screens) including copy/casing changes, styling/layout adjustments, illustration swap (SVG), and corresponding E2E expectation updates. No authentication/session/data persistence or core/shared business logic was modified; only i18n strings and presentation components were touched.
QA Recommendation: Minimal manual QA: smoke test the welcome carousel and “Configure server” screen on desktop at least across one wide and one narrow breakpoint to verify updated text (including “Get started” casing), slide order/titles, and that layout renders correctly.
Generated by CodeRabbitAI
Screenshots
Release Note
Mobile equivalent PR: mattermost/mattermost-mobile#9901