Add system setting to allow native web search in channels (#494)

* Add system setting to allow native web search in channels

* Fix e2e

Author: nickmisasi

anthropic/anthropic.go

@@ -208,17 +208,22 @@ func (a *Anthropic) buildAPIParams(state *messageState) anthropicSDK.MessageNewP
 		Messages:  state.messages,
 	}
 
+	// Add regular tools only if not disabled
 	if !state.config.ToolsDisabled {
 		params.Tools = convertTools(state.tools)
+	}
 
-		if a.isNativeToolEnabled("web_search") {
-			params.Tools = append(params.Tools, anthropicSDK.ToolUnionParam{
-				OfWebSearchTool20250305: &anthropicSDK.WebSearchTool20250305Param{
-					Name: "web_search",
-					Type: "web_search_20250305",
-				},
-			})
-		}
+	// Add native web search if:
+	// 1. Tools are not disabled, OR
+	// 2. Native web search is explicitly allowed (for channel context)
+	// AND the agent has web_search enabled in their native tools config
+	if (!state.config.ToolsDisabled || state.config.NativeWebSearchAllowed) && a.isNativeToolEnabled("web_search") {
+		params.Tools = append(params.Tools, anthropicSDK.ToolUnionParam{
+			OfWebSearchTool20250305: &anthropicSDK.WebSearchTool20250305Param{
+				Name: "web_search",
+				Type: "web_search_20250305",
+			},
+		})
 	}
 
 	if state.system != "" {

bots/bot.go

@@ -42,6 +42,15 @@ func (b *Bot) GetService() llm.ServiceConfig {
 	return b.service
 }
 
+func (b *Bot) HasNativeWebSearchEnabled() bool {
+	for _, tool := range b.cfg.EnabledNativeTools {
+		if tool == "web_search" {
+			return true
+		}
+	}
+	return false
+}
+
 func (b *Bot) SetLLMForTest(llm llm.LanguageModel) {
 	b.llm = llm
 }

config/config.go

@@ -16,17 +16,18 @@ import (
 )
 
 type Config struct {
-	Services                 []llm.ServiceConfig              `json:"services"`
-	Bots                     []llm.BotConfig                  `json:"bots"`
-	DefaultBotName           string                           `json:"defaultBotName"`
-	TranscriptGenerator      string                           `json:"transcriptBackend"`
-	EnableLLMTrace           bool                             `json:"enableLLMTrace"`
-	EnableTokenUsageLogging  bool                             `json:"enableTokenUsageLogging"`
-	AllowedUpstreamHostnames string                           `json:"allowedUpstreamHostnames"`
-	AllowUnsafeLinks         bool                             `json:"allowUnsafeLinks"`
-	EmbeddingSearchConfig    embeddings.EmbeddingSearchConfig `json:"embeddingSearchConfig"`
-	MCP                      mcp.Config                       `json:"mcp"`
-	WebSearch                WebSearchConfig                  `json:"webSearch"`
+	Services                       []llm.ServiceConfig              `json:"services"`
+	Bots                           []llm.BotConfig                  `json:"bots"`
+	DefaultBotName                 string                           `json:"defaultBotName"`
+	TranscriptGenerator            string                           `json:"transcriptBackend"`
+	EnableLLMTrace                 bool                             `json:"enableLLMTrace"`
+	EnableTokenUsageLogging        bool                             `json:"enableTokenUsageLogging"`
+	AllowedUpstreamHostnames       string                           `json:"allowedUpstreamHostnames"`
+	AllowUnsafeLinks               bool                             `json:"allowUnsafeLinks"`
+	AllowNativeWebSearchInChannels bool                             `json:"allowNativeWebSearchInChannels"`
+	EmbeddingSearchConfig          embeddings.EmbeddingSearchConfig `json:"embeddingSearchConfig"`
+	MCP                            mcp.Config                       `json:"mcp"`
+	WebSearch                      WebSearchConfig                  `json:"webSearch"`
 }
 
 type WebSearchConfig struct {
@@ -121,6 +122,15 @@ func (c *Container) AllowUnsafeLinks() bool {
 	return cfg.AllowUnsafeLinks
 }
 
+func (c *Container) AllowNativeWebSearchInChannels() bool {
+	cfg := c.cfg.Load()
+	if cfg == nil {
+		return false
+	}
+
+	return cfg.AllowNativeWebSearchInChannels
+}
+
 func (c *Container) RegisterUpdateListener(listener UpdateListener) {
 	c.listeners = append(c.listeners, listener)
 }

conversations/conversations.go

@@ -39,6 +39,10 @@ type AIThread struct {
 	UpdateAt   int64  `json:"update_at"`
 }
 
+type ConfigProvider interface {
+	AllowNativeWebSearchInChannels() bool
+}
+
 type Conversations struct {
 	prompts          *llm.Prompts
 	mmClient         mmapi.Client
@@ -49,6 +53,7 @@ type Conversations struct {
 	licenseChecker   *enterprise.LicenseChecker
 	i18n             *i18n.Bundle
 	meetingsService  MeetingsService
+	configProvider   ConfigProvider
 }
 
 // MeetingsService defines the interface for meetings functionality needed by conversations
@@ -67,6 +72,7 @@ func New(
 	licenseChecker *enterprise.LicenseChecker,
 	i18nBundle *i18n.Bundle,
 	meetingsService MeetingsService,
+	configProvider ConfigProvider,
 ) *Conversations {
 	return &Conversations{
 		prompts:          prompts,
@@ -78,6 +84,7 @@ func New(
 		licenseChecker:   licenseChecker,
 		i18n:             i18nBundle,
 		meetingsService:  meetingsService,
+		configProvider:   configProvider,
 	}
 }
 
@@ -133,8 +140,11 @@ func (c *Conversations) ProcessUserRequestWithContext(bot *bots.Bot, postingUser
 	}
 	var opts []llm.LanguageModelOption
 	if !isDM {
-		// In non-DM channels, disable tools for security but provide info about DM-only tools
 		opts = append(opts, llm.WithToolsDisabled())
+
+		if c.configProvider != nil && c.configProvider.AllowNativeWebSearchInChannels() && bot.HasNativeWebSearchEnabled() {
+			opts = append(opts, llm.WithNativeWebSearchAllowed())
+		}
 	}
 	result, err := bot.LLM().ChatCompletion(completionRequest, opts...)
 	if err != nil {

conversations/conversations_test.go

@@ -131,6 +131,7 @@ func TestConversationMentionHandling(t *testing.T) {
 				licenseChecker,
 				i18n.Init(),
 				nil,
+				nil,
 			)
 
 			// Create a mock bot

conversations/direct_message_eval_test.go

@@ -129,6 +129,7 @@ func TestDirectMessageConversations(t *testing.T) {
 				licenseChecker,
 				i18n.Init(),
 				nil,
+				nil,
 			)
 
 			// Create a mock bot for DM