Skip to content

Commit 1710285

Browse files
updating tests to account for changes in logging expectations
1 parent ce8c301 commit 1710285

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

server/plugin/webhook_test.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,6 @@ func TestHandleCommentMentionNotification(t *testing.T) {
509509
mockAPI.On("GetDirectChannel", "otherUserID", "mockBotID").Return(&model.Channel{Id: "mockChannelID"}, nil).Times(1)
510510
mockAPI.On("CreatePost", mock.Anything).Return(nil, &model.AppError{Message: "error creating post"}).Times(1)
511511
mockAPI.On("LogWarn", "Error creating mention post", "error", "error creating post").Times(1)
512-
mockAPI.On("LogWarn", "Failed to get github user info", "error", "Must connect user account to GitHub first.").Times(1)
513512
},
514513
},
515514
{
@@ -526,7 +525,6 @@ func TestHandleCommentMentionNotification(t *testing.T) {
526525
})).Return(nil).Times(1)
527526
mockAPI.On("GetDirectChannel", "otherUserID", "mockBotID").Return(&model.Channel{Id: "mockChannelID"}, nil).Times(1)
528527
mockAPI.On("CreatePost", mock.Anything).Return(&model.Post{}, nil).Times(1)
529-
mockAPI.On("LogWarn", "Failed to get github user info", "error", "Must connect user account to GitHub first.")
530528
},
531529
},
532530
}
@@ -609,7 +607,6 @@ func TestHandleCommentAuthorNotification(t *testing.T) {
609607
})).Return(nil).Times(1)
610608
mockAPI.On("GetDirectChannel", "authorUserID", "mockBotID").Return(&model.Channel{Id: "mockChannelID"}, nil).Times(1)
611609
mockAPI.On("CreatePost", mock.Anything).Return(&model.Post{}, nil, &model.AppError{Message: "error creating post"}).Times(1)
612-
mockAPI.On("LogWarn", "Failed to get github user info", "error", "Must connect user account to GitHub first.").Times(1)
613610
},
614611
},
615612
{
@@ -628,7 +625,6 @@ func TestHandleCommentAuthorNotification(t *testing.T) {
628625
_, ok := val.(**GitHubUserInfo)
629626
return ok
630627
})).Return(nil).Times(1)
631-
mockAPI.On("LogWarn", "Failed to get github user info", "error", "Must connect user account to GitHub first.").Times(1)
632628
mockAPI.On("GetDirectChannel", "authorUserID", "mockBotID").Return(&model.Channel{Id: "mockChannelID"}, nil).Times(1)
633629
mockAPI.On("CreatePost", mock.Anything).Return(&model.Post{}, nil).Times(1)
634630
},
@@ -774,7 +770,6 @@ func TestHandlePullRequestNotification(t *testing.T) {
774770
})).Return(nil).Times(1)
775771
mockAPI.On("GetDirectChannel", "authorUserID", "mockBotID").Return(&model.Channel{Id: "mockChannelID"}, nil)
776772
mockAPI.On("CreatePost", mock.Anything).Return(&model.Post{}, nil).Times(1)
777-
mockAPI.On("LogWarn", "Failed to get github user info", "error", "Must connect user account to GitHub first.").Times(1)
778773
},
779774
},
780775
{
@@ -806,7 +801,6 @@ func TestHandlePullRequestNotification(t *testing.T) {
806801
_, ok := val.(**GitHubUserInfo)
807802
return ok
808803
})).Return(nil).Times(1)
809-
mockAPI.On("LogWarn", "Failed to get github user info", "error", "Must connect user account to GitHub first.").Times(1)
810804
},
811805
},
812806
{
@@ -823,7 +817,6 @@ func TestHandlePullRequestNotification(t *testing.T) {
823817
_, ok := val.(**GitHubUserInfo)
824818
return ok
825819
})).Return(nil).Times(1)
826-
mockAPI.On("LogWarn", "Failed to get github user info", "error", "Must connect user account to GitHub first.").Times(1)
827820
},
828821
},
829822
{
@@ -990,7 +983,6 @@ func TestHandlePullRequestReviewNotification(t *testing.T) {
990983
_, ok := val.(**GitHubUserInfo)
991984
return ok
992985
})).Return(nil).Times(1)
993-
mockAPI.On("LogWarn", "Failed to get github user info", "error", "Must connect user account to GitHub first.")
994986
},
995987
},
996988
}

0 commit comments

Comments
 (0)