Updated the getMutedUser function to return proper response

Author: Kshitij-Katiyar

server/plugin/command.go

@@ -136,23 +136,27 @@ func (p *Plugin) postCommandResponse(args *model.CommandArgs, text string) {
 	p.client.Post.SendEphemeralPost(args.UserId, post)
 }
 
-func (p *Plugin) getMutedUsernames(userInfo *GitHubUserInfo) []string {
+func (p *Plugin) getMutedUsernames(userInfo *GitHubUserInfo) ([]string, error) {
 	var mutedUsernameBytes []byte
 	err := p.store.Get(userInfo.UserID+"-muted-users", &mutedUsernameBytes)
 	if err != nil {
-		return nil
+		return nil, err
 	}
 	mutedUsernames := string(mutedUsernameBytes)
 	var mutedUsers []string
 	if len(mutedUsernames) == 0 {
-		return mutedUsers
+		return mutedUsers, nil
 	}
 	mutedUsers = strings.Split(mutedUsernames, ",")
-	return mutedUsers
+	return mutedUsers, nil
 }
 
 func (p *Plugin) handleMuteList(_ *model.CommandArgs, userInfo *GitHubUserInfo) string {
-	mutedUsernames := p.getMutedUsernames(userInfo)
+	mutedUsernames, err := p.getMutedUsernames(userInfo)
+	if err != nil {
+		return "Some error occurred getting muted users. Please try again later"
+	}
+
 	var mutedUsers string
 	for _, user := range mutedUsernames {
 		mutedUsers += fmt.Sprintf("- %v\n", user)
@@ -173,7 +177,11 @@ func contains(s []string, e string) bool {
 }
 
 func (p *Plugin) handleMuteAdd(_ *model.CommandArgs, username string, userInfo *GitHubUserInfo) string {
-	mutedUsernames := p.getMutedUsernames(userInfo)
+	mutedUsernames, err := p.getMutedUsernames(userInfo)
+	if err != nil {
+		return "Some error occurred getting muted users. Please try again later"
+	}
+
 	if contains(mutedUsernames, username) {
 		return username + " is already muted"
 	}
@@ -190,7 +198,7 @@ func (p *Plugin) handleMuteAdd(_ *model.CommandArgs, username string, userInfo *
 		mutedUsers = username
 	}
 
-	_, err := p.store.Set(userInfo.UserID+"-muted-users", []byte(mutedUsers))
+	_, err = p.store.Set(userInfo.UserID+"-muted-users", []byte(mutedUsers))
 	if err != nil {
 		return "Error occurred saving list of muted users"
 	}
@@ -199,11 +207,15 @@ func (p *Plugin) handleMuteAdd(_ *model.CommandArgs, username string, userInfo *
 }
 
 func (p *Plugin) handleUnmute(_ *model.CommandArgs, username string, userInfo *GitHubUserInfo) string {
-	mutedUsernames := p.getMutedUsernames(userInfo)
+	mutedUsernames, err := p.getMutedUsernames(userInfo)
+	if err != nil {
+		return "Some error occurred getting muted users. Please try again later"
+	}
+
 	userToMute := []string{username}
 	newMutedList := arrayDifference(mutedUsernames, userToMute)
 
-	_, err := p.store.Set(userInfo.UserID+"-muted-users", []byte(strings.Join(newMutedList, ",")))
+	_, err = p.store.Set(userInfo.UserID+"-muted-users", []byte(strings.Join(newMutedList, ",")))
 	if err != nil {
 		return "Error occurred unmuting users"
 	}

server/plugin/command_test.go

@@ -344,15 +344,16 @@ func TestGetMutedUsernames(t *testing.T) {
 	tests := []struct {
 		name       string
 		setup      func()
-		assertions func(t *testing.T, result []string)
+		assertions func(t *testing.T, result []string, err error)
 	}{
 		{
 			name: "Error retrieving muted usernames",
 			setup: func() {
 				mockKvStore.EXPECT().Get("mockUserID-muted-users", gomock.Any()).Return(errors.New("error retrieving muted users")).Times(1)
 			},
-			assertions: func(t *testing.T, result []string) {
+			assertions: func(t *testing.T, result []string, err error) {
 				assert.Nil(t, result)
+				assert.ErrorContains(t, err, "error retrieving muted users")
 			},
 		},
 		{
@@ -363,7 +364,7 @@ func TestGetMutedUsernames(t *testing.T) {
 					return nil
 				}).Times(1)
 			},
-			assertions: func(t *testing.T, result []string) {
+			assertions: func(t *testing.T, result []string, _ error) {
 				assert.Equal(t, []string(nil), result)
 			},
 		},
@@ -376,7 +377,7 @@ func TestGetMutedUsernames(t *testing.T) {
 					return nil
 				}).Times(1)
 			},
-			assertions: func(t *testing.T, result []string) {
+			assertions: func(t *testing.T, result []string, _ error) {
 				assert.Equal(t, []string{"user1", "user2", "user3"}, result)
 			},
 		},
@@ -385,9 +386,9 @@ func TestGetMutedUsernames(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			tc.setup()
 
-			mutedUsernames := p.getMutedUsernames(userInfo)
+			mutedUsernames, err := p.getMutedUsernames(userInfo)
 
-			tc.assertions(t, mutedUsernames)
+			tc.assertions(t, mutedUsernames, err)
 		})
 	}
 }
@@ -409,7 +410,7 @@ func TestHandleMuteList(t *testing.T) {
 				mockKvStore.EXPECT().Get("mockUserID-muted-users", gomock.Any()).Return(errors.New("error retrieving muted users")).Times(1)
 			},
 			assertions: func(t *testing.T, result string) {
-				assert.Equal(t, "You have no muted users", result)
+				assert.Equal(t, "Some error occurred getting muted users. Please try again later", result)
 			},
 		},
 		{