[MM-944]: Typescript migration and converting github_label_selector to TS (#851)

* [MM-944]: Typescript migration and converting github_label_selector to TS

* [MM-944]

* [MM-944]: removed the use of any

* [MM-944]: fixed lint

Author: Kshitij-Katiyar

webapp/.eslintrc.json

@@ -1,21 +1,16 @@
 {
   "extends": [
-      "eslint:recommended",
-      "plugin:react-hooks/recommended"
+    "eslint:recommended",
+    "plugin:react-hooks/recommended"
   ],
+  "parser": "@typescript-eslint/parser",
   "parserOptions": {
-    "ecmaVersion": 8,
-    "sourceType": "module",
-    "ecmaFeatures": {
-      "jsx": true,
-      "impliedStrict": true,
-      "modules": true,
-      "experimentalObjectRestSpread": true
-    }
+    "project": "./tsconfig.json",
+    "tsconfigRootDir": "./"
   },
-  "parser": "babel-eslint",
   "plugins": [
     "react",
+    "@typescript-eslint",
     "import"
   ],
   "env": {
@@ -35,7 +30,12 @@
     "beforeEach": true
   },
   "settings": {
-    "import/resolver": "webpack"
+    "import/resolver": {
+      "typescript": {}
+    },
+    "import/parsers": {
+      "@typescript-eslint/parser": [".ts", ".tsx"]
+    }
   },
   "rules": {
     "array-bracket-spacing": [
@@ -639,7 +639,7 @@
       ],
       "rules": {
         "@typescript-eslint/ban-ts-ignore": 0,
-        "@typescript-eslint/ban-types": 1,
+        "@typescript-eslint/ban-types": 0,
         "@typescript-eslint/ban-ts-comment": 0,
         "@typescript-eslint/no-var-requires": 0,
         "@typescript-eslint/prefer-interface": 0,

webapp/package-lock.json

@@ -34,6 +34,7 @@
     "@types/react-intl": "3.0.0",
     "@types/react-redux": "7.1.9",
     "@types/react-router-dom": "5.1.5",
+    "@types/react-select": "3.1.0",
     "@types/react-transition-group": "4.4.0",
     "@typescript-eslint/eslint-plugin": "4.1.1",
     "@typescript-eslint/parser": "4.1.1",
@@ -46,6 +47,7 @@
     "enzyme-adapter-react-16": "1.15.4",
     "enzyme-to-json": "3.5.0",
     "eslint": "7.9.0",
+    "eslint-import-resolver-typescript": "3.6.1",
     "eslint-import-resolver-webpack": "0.12.2",
     "eslint-plugin-import": "2.22.0",
     "eslint-plugin-react": "7.20.6",

webapp/package.json

@@ -4,7 +4,7 @@
 import React, {PureComponent} from 'react';
 import PropTypes from 'prop-types';
 
-import IssueAttributeSelector from 'components/issue_attribute_selector';
+import IssueAttributeSelector from '@/components/issue_attribute_selector';
 
 export default class GithubAssigneeSelector extends PureComponent {
     static propTypes = {

webapp/src/components/github_assignee_selector/github_assignee_selector.jsx

@@ -7,8 +7,8 @@ import PropTypes from 'prop-types';
 import debounce from 'debounce-promise';
 import AsyncSelect from 'react-select/async';
 
-import {getStyleForReactSelect} from 'utils/styles';
-import Client from 'client';
+import {getStyleForReactSelect} from '@/utils/styles';
+import Client from '@/client';
 
 const searchDebounceDelay = 400;
 

webapp/src/components/github_issue_selector.jsx

@@ -2,21 +2,25 @@
 // See LICENSE.txt for license information.
 
 import React, {PureComponent} from 'react';
-import PropTypes from 'prop-types';
-
-import IssueAttributeSelector from 'components/issue_attribute_selector';
-
-export default class GithubLabelSelector extends PureComponent {
-    static propTypes = {
-        repoName: PropTypes.string.isRequired,
-        theme: PropTypes.object.isRequired,
-        selectedLabels: PropTypes.array.isRequired,
-        onChange: PropTypes.func.isRequired,
-        actions: PropTypes.shape({
-            getLabelOptions: PropTypes.func.isRequired,
-        }).isRequired,
-    };
 
+import {Theme} from 'mattermost-redux/types/preferences';
+
+import IssueAttributeSelector, {IssueAttributeSelectorSelection} from '../issue_attribute_selector';
+
+import {GitHubLabelSelectorDispatchProps} from '.';
+
+type Props = GitHubLabelSelectorDispatchProps & {
+    repoName: string;
+    theme: Theme;
+    selectedLabels: string[];
+    onChange: (selection: string[]) => void;
+};
+
+type Option = {
+    name: string;
+};
+
+export default class GithubLabelSelector extends PureComponent<Props> {
     loadLabels = async () => {
         if (this.props.repoName === '') {
             return [];
@@ -32,13 +36,19 @@ export default class GithubLabelSelector extends PureComponent {
             return [];
         }
 
-        return options.data.map((option) => ({
+        return options.data.map((option: Option) => ({
             value: option.name,
             label: option.name,
         }));
     };
 
-    onChange = (selection) => this.props.onChange(selection.map((s) => s.value));
+    onChange = (selection: IssueAttributeSelectorSelection) => {
+        if (!selection || !Array.isArray(selection)) {
+            return;
+        }
+
+        this.props.onChange(selection.map((s) => s.value));
+    }
 
     render() {
         return (