Bump Go version to 1.24.6 and golangci-lint to v2.6.0 (#944)

* Bump Go version to 1.24.6 and golangci-lint to v2.6.0

Updates:
- Update Go version from 1.23.0 to 1.24.6
- Remove toolchain directive
- Update golangci-lint from v1.64.7 to v2.6.0
- Update .golangci.yml to version 2 format
- Update mattermost-govet to 7d8db289e508999dfcac47b97c9490a0fec12d66
- Update CI workflow golang-version to 1.24.6

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* Fix linter errors and align golangci-lint config with Jira plugin

- Fix bodyclose errors in client/client_test.go
- Fix misspelling in build/pluginctl/logs.go (configration -> configuration)
- Align golangci-lint config with mattermost-plugin-jira
  - Update goconst.min-len from 2 to 3
  - Remove extra exclude-rules for revive linter

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

---------

Co-authored-by: Claude <[email protected]>

Author: wiggin77

.github/workflows/ci.yml

@@ -18,4 +18,4 @@ jobs:
     uses: mattermost/actions-workflows/.github/workflows/plugin-ci.yml@main
     secrets: inherit
     with:
-      golang-version: "1.23"
+      golang-version: "1.24.6"

.golangci.yml

@@ -1,10 +1,12 @@
+version: 2
+
 run:
   timeout: 5m
   modules-download-mode: readonly
 
 linters-settings:
   goconst:
-    min-len: 2
+    min-len: 3
     min-occurrences: 2
   gofmt:
     simplify: true
@@ -16,29 +18,92 @@ linters-settings:
       - fieldalignment
   misspell:
     locale: US
+  revive:
 
 linters:
   disable-all: true
   enable:
     - bodyclose
-    # - errcheck
-    # - goconst
+    - errcheck
     - gocritic
-    - gofmt
-    - goimports
-    # - gosec
-    - gosimple
+    - gosec
     - govet
     - ineffassign
-    # - misspell
+    - misspell
     - nakedret
     - revive
     - staticcheck
-    - stylecheck
-    - typecheck
     - unconvert
     - unused
     - whitespace
+  exclusions:
+    rules:
+      - linters:
+          - revive
+        text: var-naming|error-naming|exported|increment-decrement|error-strings|if-return|unused-parameter|blank-imports|empty-block|package-comments
+      - linters:
+          - errcheck
+        text: Error return value
+      - linters:
+          - staticcheck
+        text: SA1019
+      - linters:
+          - staticcheck
+        text: ST1023
+      - linters:
+          - staticcheck
+        text: ST1012
+      - linters:
+          - staticcheck
+        text: ST1005
+      - linters:
+          - staticcheck
+        text: QF1011
+      - linters:
+          - staticcheck
+        text: QF1001
+      - linters:
+          - staticcheck
+        text: QF1003
+      - linters:
+          - staticcheck
+        text: QF1012
+      - linters:
+          - staticcheck
+        text: QT1019
+      - linters:
+          - staticcheck
+        text: QF1008
+      - linters:
+          - staticcheck
+        text: QF1004
+      - linters:
+          - staticcheck
+        text: ST1019
+      - linters:
+          - staticcheck
+        text: QF1006
+      - linters:
+          - staticcheck
+        text: QF1002
+      - linters:
+          - staticcheck
+        text: QF1007
+      - linters:
+          - gosec
+        text: G104
+      - linters:
+          - gosec
+        text: G304
+      - linters:
+          - gosec
+        text: G301
+
+formatters:
+  disable-all: true
+  enable:
+    - gofmt
+    - goimports
 
 issues:
   exclude-rules:
@@ -50,15 +115,6 @@ issues:
     - path: server/configuration.go
       linters:
         - unused
-    - linters:
-        - revive
-      text: unused-parameter
-    - linters:
-        - revive
-      text: var-naming
-    - linters:
-        - revive
-      text: error-strings
     - path: _test\.go
       linters:
         - bodyclose

Makefile

@@ -158,9 +158,9 @@ apply:
 ## Install go tools
 install-go-tools:
 	@echo Installing go tools
-	$(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.7
+	$(GO) install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.6.0
 	$(GO) install gotest.tools/[email protected]
-	$(GO) install github.com/mattermost/mattermost-govet/v2@3f08281c344327ac09364f196b15f9a81c7eff08
+	$(GO) install github.com/mattermost/mattermost-govet/v2@7d8db289e508999dfcac47b97c9490a0fec12d66
 
 ## Runs eslint and golangci-lint
 .PHONY: check-style

build/pluginctl/logs.go

@@ -181,7 +181,7 @@ func checkJSONLogsSetting(ctx context.Context, client *model.Client4) error {
 		return fmt.Errorf("failed to fetch config: %w", err)
 	}
 	if cfg.LogSettings.FileJson == nil || !*cfg.LogSettings.FileJson {
-		return errors.New("JSON output for file logs are disabled. Please enable LogSettings.FileJson via the configration in Mattermost.") //nolint:revive,stylecheck
+		return errors.New("JSON output for file logs are disabled. Please enable LogSettings.FileJson via the configuration in Mattermost.") //nolint:revive,stylecheck
 	}
 
 	return nil

client/client_test.go

@@ -23,14 +23,15 @@ import (
 func TestRoundTripper(t *testing.T) {
 	t.Run("Valid response", func(t *testing.T) {
 		pluginAPI := &plugintest.API{}
-		pluginAPI.On("PluginHTTP", mock.AnythingOfType("*http.Request")).Return(&http.Response{StatusCode: http.StatusOK})
+		pluginAPI.On("PluginHTTP", mock.AnythingOfType("*http.Request")).Return(&http.Response{StatusCode: http.StatusOK, Body: http.NoBody})
 
 		roundTripper := pluginAPIRoundTripper{api: pluginAPI}
 		req, err := http.NewRequest(http.MethodPost, "url", nil)
 		require.NoError(t, err)
 
 		resp, err := roundTripper.RoundTrip(req)
 		require.NoError(t, err)
+		defer resp.Body.Close()
 		require.Equal(t, http.StatusOK, resp.StatusCode)
 	})
 
@@ -44,6 +45,9 @@ func TestRoundTripper(t *testing.T) {
 		require.NoError(t, err)
 
 		resp, err := roundTripper.RoundTrip(req)
+		if resp != nil && resp.Body != nil {
+			defer resp.Body.Close()
+		}
 		require.Nil(t, resp)
 		require.Error(t, err)
 	})

go.mod

@@ -1,8 +1,6 @@
 module github.com/mattermost/mattermost-plugin-github
 
-go 1.23.0
-
-toolchain go1.23.8
+go 1.24.6
 
 require (
 	github.com/Masterminds/sprig/v3 v3.2.2