Issues/Enhancement found in RC v2.5.0-rc1

[Yash-Chakerverti]

Below are the issues/enhancements found in the RC v2.5.0-rc1:-

Issues:-

• It is possible to unsubscribe any repository subscription from the channel, even if the subscription or repository does not exist. #870
• After setting the default repository, the Create Issue modal does not preselect the default repository in the repository field. #929
• The plugin does not validate the provided username before adding it to the mute list. It also does not check if the username exists in the mute list before attempting to remove it. #920
• In plugin configuration, if an invalid organization is added first and a valid one later, running the Create Issue command does not display any repositories. However, if the valid organization is added first followed by the invalid one, repositories are displayed correctly in the Create Issue modal.
• When adding a subscription to a channel with an invalid repository name:- a) Sometimes the subscription is created. b) Sometimes the expected error Unknown repository is shown. c) Sometimes the plugin crashes and shows the error: /github command crashed the github plugin. Please contact your system administrator

Enhancements:-

• After disconnecting the GitHub account, the GitHub logo disappears from the left-hand side.
• The github help command does not include information about the setup and about commands.
• The creator profile link in issue and pull request notifications opens in the same Mattermost tab instead of opening in a new tab.
• The help command is only able to run when the user is connected to github.
• Tooltip on the pull request number shows "Issue" instead of "Pull Request" in the GitHub RHS.
• The GitHub announcement modal does not display the word or character limit.

[Yash-Chakerverti]

Following issues are fixed in #934 and #938

1. Opens the author’s GitHub profile in a new tab when clicking on the author name in the PR/issue tooltip.
2. Users can run the help command without needing to connect to GitHub.
3. Character limit is displayed properly in the announcement modal.
4. Users can set up the default repo even if multiple organization locks are applied.
5. Users can see repositories in the create issue modal even if an invalid repo is added first in the org lock, followed by a valid repo.
6. Tooltip on the pull request number shows "Issue" instead of "Pull Request" in the GitHub RHS.
7. User is able to unsubribe the only available subscriptions in the channel.
8. The plugin does not validate the provided username before adding it to the mute list. It also does not check if the username exists in the mute list before attempting to remove it.
9. After setting the default repository, the Create Issue modal does not preselect the default repository in the repository field.

[Yash-Chakerverti]

Following issues/enhancements are still pending:-

Issues:-

1. When adding a subscription to a channel with an invalid repository name:- a) Sometimes the expected error Unknown repository is shown. b) Sometimes the plugin crashes and shows the error: /github command crashed the github plugin. Please contact your system administrator

Enhancements:-

1. After disconnecting the GitHub account, the GitHub logo disappears from the left-hand side.

[Yash-Chakerverti]

Since the pending issues are pre-existing in the last release too, I have logged a seperate issue for them and removing them from the list of RC issues.

#939