Error log spam for every active user that does not have a github account connected #941
Description
After a restart of the server (or after deactivating and re-enabling the plugin), I get massive error log spam:
error [2025-11-16 02:44:27.146 +01:00] failed to get GitHub user info caller="app/plugin_api.go:1127" plugin_id=github userid=8hd4coywmpy4xntyxqn3d3ughw error="Must connect user account to GitHub first."
error [2025-11-16 02:44:27.282 +01:00] failed to get GitHub user info caller="app/plugin_api.go:1127" plugin_id=github userid=h31sa3garf81myqi4zg1zcmkpr error="Must connect user account to GitHub first."
error [2025-11-16 02:44:27.298 +01:00] failed to get GitHub user info caller="app/plugin_api.go:1127" plugin_id=github userid=nogjdcs3p7r6dkj7ff7k6ptoqe error="Must connect user account to GitHub first."
error [2025-11-16 02:44:27.323 +01:00] failed to get GitHub user info caller="app/plugin_api.go:1127" plugin_id=github userid=bwx5dms9z3rudx816746jh831a error="Must connect user account to GitHub first."
error [2025-11-16 02:44:27.350 +01:00] failed to get GitHub user info caller="app/plugin_api.go:1127" plugin_id=github userid=bdurtwow7j81xchmqejet53ijh error="Must connect user account to GitHub first."
error [2025-11-16 02:44:27.391 +01:00] failed to get GitHub user info caller="app/plugin_api.go:1127" plugin_id=github userid=a5ct7wopzb8yxyppc9rp9dt9pc error="Must connect user account to GitHub first."
error [2025-11-16 02:44:27.530 +01:00] failed to get GitHub user info caller="app/plugin_api.go:1127" plugin_id=github userid=6dpct4bkjbrhuqrt94fmuuoupc error="Must connect user account to GitHub first."
error [2025-11-16 02:44:27.636 +01:00] failed to get GitHub user info caller="app/plugin_api.go:1127" plugin_id=github userid=tuk4g4irrpr958scfzz57nuboe error="Must connect user account to GitHub first."
error [2025-11-16 02:44:27.655 +01:00] failed to get GitHub user info caller="app/plugin_api.go:1127" plugin_id=github userid=6556j96qc7d8defqmrxwxsiuhw error="Must connect user account to GitHub first."
error [2025-11-16 02:44:27.669 +01:00] failed to get GitHub user info caller="app/plugin_api.go:1127" plugin_id=github userid=rk9a8nkk9jgdmm77ppnkedpwoh error="Must connect user account to GitHub first."
It looks like this is logged for every single Mattermost user who has a client connected to Mattermost and no Github account linked.
While logging an error when you try to perform an action that requires a linked GitHub account makes perfect sense, it seems strange that what I assume is merely checking whether the user has a GitHub account linked results in such log messages.
It looks like this error log message is triggered whenever a request to /plugins/github/api/v1/connected?reminder=true is sent. Maybe other requests trigger it as well, but I could confirm that simply reloading the Mattermost webapp from a user that has no GitHub connection is enough to trigger this log message.