[MM-493]: Fixed the bug 'don't have the permissions to create subscriptions for this project (#495)

Kshitij-Katiyar · web-flow · commit 69ab85a2bc2c · 2024-05-17T10:17:55.000-04:00
* [MM-493]: Fixed the bug 'don't have the permissions to create subscriptions for this project'

* [MM-493]: Fixed lint errors

* [MM-493]: Fixed review comments

* [MM-493]: Fixed CI
diff --git a/server/webhook.go b/server/webhook.go
@@ -230,8 +230,11 @@ func (p *Plugin) permissionToProject(ctx context.Context, userID, namespace, pro
 		return false
 	}
 
-	// Check for guest level permissions
-	if result.Permissions.ProjectAccess == nil || result.Permissions.ProjectAccess.AccessLevel == gitlabLib.GuestPermissions {
+	// User permission for the project
+	userPermission := result.Permissions
+
+	// Check if the user has guest permission or less for both project and group level
+	if (userPermission.ProjectAccess != nil && userPermission.ProjectAccess.AccessLevel <= gitlabLib.GuestPermissions) || (userPermission.GroupAccess != nil && userPermission.GroupAccess.AccessLevel <= gitlabLib.GuestPermissions) {
 		return false
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -230,8 +230,11 @@ func (p *Plugin) permissionToProject(ctx context.Context, userID, namespace, pro`
`230`	`230`	`return false`
`231`	`231`	`}`
`232`	`232`
`233`		`- // Check for guest level permissions`
`234`		`- if result.Permissions.ProjectAccess == nil \|\| result.Permissions.ProjectAccess.AccessLevel == gitlabLib.GuestPermissions {`
	`233`	`+ // User permission for the project`
	`234`	`+ userPermission := result.Permissions`
	`235`	`+`
	`236`	`+ // Check if the user has guest permission or less for both project and group level`
	`237`	`+ if (userPermission.ProjectAccess != nil && userPermission.ProjectAccess.AccessLevel <= gitlabLib.GuestPermissions) \|\| (userPermission.GroupAccess != nil && userPermission.GroupAccess.AccessLevel <= gitlabLib.GuestPermissions) {`
`235`	`238`	`return false`
`236`	`239`	`}`
`237`	`240`