Skip to content

Commit 1bb01b6

Browse files
improved error message on unit conversion error
1 parent 7f75b82 commit 1bb01b6

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

src/sbmlsim/units.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,10 +329,19 @@ def normalize_changes(
329329
)
330330
raise err
331331
else:
332-
item = Q_(item, uinfo[key])
333332
logger.warning(
334333
f"No units provided, assuming dictionary units: {key} = {item}"
335334
)
335+
try:
336+
# convert to model units
337+
item = Q_(item, uinfo[key])
338+
except DimensionalityError as err:
339+
logger.error(
340+
f"DimensionalityError "
341+
f"'{key} = {item}'."
342+
f"\n{err}"
343+
)
344+
336345
changes_normed[key] = item
337346

338347
return changes_normed

0 commit comments

Comments
 (0)