Skip to content

Commit 6722c12

Browse files
Merge pull request #80 from matthiaskoenig/develop
Changes for v0.1.13
2 parents 139390e + 94d66ea commit 6722c12

File tree

28 files changed

+325
-4096
lines changed

28 files changed

+325
-4096
lines changed

.github/CONTRIBUTING.rst

Lines changed: 172 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,172 @@
1+
============
2+
Contributing
3+
============
4+
5+
Contributions are welcome, and they are greatly appreciated! Every little bit
6+
helps, and credit will always be given.
7+
8+
You can contribute in many ways:
9+
10+
Report Bugs
11+
===========
12+
13+
Report bugs at https://github.com/matthiaskoenig/sbmlsim/issues.
14+
15+
If you are reporting a bug, please follow the template guide lines. The more
16+
detailed your report, the easier and thus faster we can help you.
17+
18+
Fix Bugs
19+
========
20+
21+
Look through the GitHub issues for bugs. Anything tagged with "bug" and "help
22+
wanted" is open to whoever wants to implement it.
23+
24+
Implement Features
25+
==================
26+
27+
Look through the GitHub issues for features. Anything tagged with "enhancement"
28+
and "help wanted" is open to whoever wants to implement it.
29+
30+
Write Documentation
31+
===================
32+
33+
sbmlsim could always use more documentation, whether as part of the official
34+
documentation, in docstrings, or even on the web in blog posts, articles, and
35+
such.
36+
37+
Submit Feedback
38+
===============
39+
40+
The best way to send feedback is to file an issue at
41+
https://github.com/matthiaskoenig/sbmlsim/issues.
42+
43+
If you are proposing a feature:
44+
45+
* Explain in detail how it would work.
46+
* Keep the scope as narrow as possible, to make it easier to implement.
47+
* Remember that this is a volunteer-driven project, and that contributions are
48+
welcome :)
49+
50+
Get Started!
51+
============
52+
53+
Ready to contribute? Here's how to set up sbmlsim for local development.
54+
55+
1. Fork the https://github.com/matthiaskoenig/sbmlsim repository on GitHub. If you
56+
have never done this before, `follow the official guide
57+
<https://guides.github.com/activities/forking/>`_
58+
2. Clone your fork locally as described in the same guide.
59+
3. Install your local copy into a a Python virtual environment. You can `read
60+
this guide to learn more
61+
<https://realpython.com/python-virtual-environments-a-primer/>`_ about them
62+
and how to create one. Alternatively, particularly if you are a Windows or
63+
Mac user, you can also use `Anaconda <https://docs.anaconda.com/anaconda/>`_.
64+
Assuming you have virtualenvwrapper installed, this is how you set up your
65+
fork for local development
66+
67+
.. code-block:: console
68+
69+
mkvirtualenv sbmlsim
70+
cd sbmlsim/
71+
pip install -e ".[development]"
72+
73+
4. Create a branch for local development using the ``develop`` branch as a
74+
starting point. Use ``fix``, ``refactor``, or ``feat`` as a prefix
75+
76+
.. code-block:: console
77+
78+
git checkout devel
79+
git checkout -b fix-name-of-your-bugfix
80+
81+
Now you can make your changes locally.
82+
83+
5. When making changes locally, it is helpful to ``git commit`` your work
84+
regularly. On one hand to save your work and on the other hand, the smaller
85+
the steps, the easier it is to review your work later. Please use `semantic
86+
commit messages
87+
<http://karma-runner.github.io/2.0/dev/git-commit-msg.html>`_.
88+
89+
.. code-block:: console
90+
91+
git add .
92+
git commit -m "fix: Your summary of changes"
93+
94+
6. When you're done making changes, check that your changes pass our test suite (with
95+
exception of flake8).
96+
This is all included with tox
97+
98+
.. code-block:: console
99+
100+
tox
101+
102+
You can run all tests in parallel using detox. To get detox, just pip install
103+
it into your virtualenv.
104+
105+
To fix the isort and black tests use
106+
107+
.. code-block:: console
108+
109+
isort src/sbmlsim
110+
black src/sbmlsim --exclude resources
111+
112+
7. Push your branch to GitHub.
113+
114+
.. code-block:: console
115+
116+
git push origin fix-name-of-your-bugfix
117+
118+
8. Open the link displayed in the message when pushing your new branch in order
119+
to submit a pull request. Please follow the template presented to you in the
120+
web interface to complete your pull request.
121+
122+
For larger features that you want to work on collaboratively with other sbmlsim
123+
team members, you may consider to first request to join the sbmlsim developers
124+
team to get write access to the repository so that you can create a branch in
125+
the main repository (or simply ask the maintainer to create a branch for you).
126+
Once you have a new branch you can push your changes directly to the main
127+
repository and when finished, submit a pull request from that branch to
128+
``develop``.
129+
130+
Pull Request Guidelines
131+
-----------------------
132+
133+
Before you submit a pull request, check that it meets these guidelines:
134+
135+
1. The pull request should include tests in the ``sbmlsim/test``
136+
directory. Except in rare circumstances, code coverage must
137+
not decrease (as reported by codecov which runs automatically when
138+
you submit your pull request)
139+
2. If the pull request adds functionality, the docs should be
140+
updated. Put your new functionality into a function with a
141+
docstring.
142+
3. The pull request will be tested for several different Python versions.
143+
4. Someone from the @matthiaskoenig/sbmlsim-core team will review your work and guide
144+
you to a successful contribution.
145+
146+
Unit tests and benchmarks
147+
-------------------------
148+
149+
sbmlsim uses `pytest <http://docs.pytest.org/en/latest/>`_ for its
150+
unit-tests and new features should in general always come with new
151+
tests that make sure that the code runs as intended.
152+
153+
To run all tests do::
154+
155+
(sbmlsim)$ pytest
156+
157+
Branching model
158+
---------------
159+
160+
``develop``
161+
Is the branch all pull-requests should be based on.
162+
``master``
163+
Is only touched by maintainers and is the branch with only tested, reviewed
164+
code that is released or ready for the next release.
165+
``{fix, bugfix, doc, feature}/descriptive-name``
166+
Is the recommended naming scheme for smaller improvements, bugfixes,
167+
documentation improvement and new features respectively.
168+
169+
Please use concise descriptive commit messages and consider using
170+
``git pull --rebase`` when you update your own fork to avoid merge commits.
171+
172+
Thank you very much for contributing to sbmlsim!
Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
---
2+
name: Bug report
3+
about: Report a bug to help improve this project
4+
---
5+
6+
<!--
7+
8+
Before you create a new problem report, please look through the list of existing open
9+
and closed issues to see if there are similar ones.
10+
11+
https://github.com/matthiaskoenig/sbmlsim/issues
12+
13+
-->
14+
15+
#### Problem description
16+
17+
Please explain:
18+
* **what** you tried to achieve,
19+
* **how** you went about it (referring to the code sample), and
20+
* **why** the current behaviour is a problem and what output
21+
you expected instead.
22+
23+
#### Code Sample
24+
25+
Create a [minimal, complete, verifiable example](https://stackoverflow.com/help/mcve).
26+
27+
<!-- Paste your code between the ``` tickmarks below or link to a gist. -->
28+
```python
29+
```
30+
31+
<!-- If there was a crash, please include the traceback between the ``` tickmarks below. -->
32+
```
33+
```
34+
35+
### Context
36+
37+
<!-- Run the following code and paste the output between the ``` tickmarks below
38+
inside the details block.
39+
40+
python -c "import sbmlsim;sbmlsim.show_versions()"
41+
42+
-->
43+
44+
<details>
45+
46+
```
47+
```
48+
49+
</details>
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
---
2+
name: Question
3+
about: Ask a question
4+
---
5+
6+
### Checklist
7+
8+
<!-- To help keep this issue tracker clean and focused, please make sure that you have
9+
tried *all* of the following resources before submitting your question. -->
10+
11+
- [ ] I searched the [documentation](https://sbmlutils.readthedocs.io).
12+
- [ ] I looked through [similar issues on GitHub](https://github.com/matthiaskoenig/sbmlutils/issues).
13+
14+
### Question
15+
16+
<!-- Please ask your question here. -->
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
---
5+
6+
### Checklist
7+
8+
<!-- Please make sure you check all these items before submitting your feature request. -->
9+
10+
- [ ] There are [no similar issues or pull requests](https://github.com/matthiaskoenig/sbmlutils/issues) for this yet.
11+
12+
### Is your feature related to a problem? Please describe it.
13+
14+
<!--
15+
A clear and concise description of what you are trying to achieve.
16+
"I want to be able to [...] but I can't because [...]".
17+
-->
18+
19+
## Describe the solution you would like.
20+
21+
<!--
22+
A clear and concise description of what you would want to happen.
23+
For API changes, try to provide a code snippet of what you would like the new API to
24+
look like.
25+
-->
26+
27+
## Describe alternatives you considered
28+
29+
<!--
30+
Please describe any alternative solutions or features you've considered to solve
31+
your problem and why they wouldn't solve it.
32+
-->
33+
34+
## Additional context
35+
36+
<!-- Provide any additional context, screenshots, tracebacks, etc. about the feature here. -->

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Ref: https://help.github.com/en/github/building-a-strong-community/configuring-issue-templates-for-your-repository#configuring-the-template-chooser
2+
blank_issues_enabled: true

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
* [ ] fix #(issue number)
2+
* [ ] description of feature/fix
3+
* [ ] tests added/passed
4+
* [ ] add an entry to the [next release](../release-notes/next-release.md)

.github/SUPPORT.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
=======
2+
Support
3+
=======
4+
5+
* You can post questions in `GitHub issues
6+
<https://github.com/matthiaskoenig/sbmlsim/issues>`_.

.github/workflows/main.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,3 @@ jobs:
8181
body_path: "release-notes/${{ steps.tag.outputs.version }}.md"
8282
draft: false
8383
prerelease: false
84-
- name: Pull request to master
85-
uses: vsoch/pull-request-action@1.0.6
86-
env:
87-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
88-
PULL_REQUEST_FROM_BRANCH: "develop"
89-
PULL_REQUEST_BRANCH: "master"

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ __pycache__
2323
# documentation
2424
docs_builder/_build/
2525

26-
26+
src/sbmlsim/examples/experiments/glucose/results/DoseResponseExperiment/DoseResponseExperiment_fig1.svg
2727
src/sbmlsim/examples/experiments/repressilator/RepressilatorExperiment/RepressilatorExperiment_task_tc.h5
2828
src/sbmlsim/examples/experiments/midazolam/results/
2929
src/sbmlsim/examples/experiments/midazolam/results_fit/

MANIFEST.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,3 @@ include README.rst
33

44
recursive-include src/sbmlsim/test/data *
55
recursive-include src/sbmlsim/resources/ *
6-
recursive-include src/sbmlsim/report/templates *

0 commit comments

Comments
 (0)