bugfix for failing optimizations

matthiaskoenig · matthiaskoenig · commit cb314a300ad4 · 2025-11-18T18:33:50.000+01:00
diff --git a/src/sbmlsim/fit/analysis.py b/src/sbmlsim/fit/analysis.py
@@ -916,8 +916,9 @@ def plot_traces(self, path: Path) -> None:
 
         for run in range(self.optres.size):
             df_run = self.optres.df_traces[self.optres.df_traces.run == run]
+            # prepare plot for traces
             ax.plot(
-                len(df_run) - 1, df_run.cost.values[-1], "o", color="black", alpha=0.8
+                len(df_run) - 1, df_run.cost.max(skipna=True), "o", color="black", alpha=0.8
             )
 
         ax.set_xlabel("Optimization step")

Original file line number	Diff line number	Diff line change
`@@ -916,8 +916,9 @@ def plot_traces(self, path: Path) -> None:`
`916`	`916`
`917`	`917`	`for run in range(self.optres.size):`
`918`	`918`	`df_run = self.optres.df_traces[self.optres.df_traces.run == run]`
	`919`	`+ # prepare plot for traces`
`919`	`920`	`ax.plot(`
`920`		`- len(df_run) - 1, df_run.cost.values[-1], "o", color="black", alpha=0.8`
	`921`	`+ len(df_run) - 1, df_run.cost.max(skipna=True), "o", color="black", alpha=0.8`
`921`	`922`	`)`
`922`	`923`
`923`	`924`	`ax.set_xlabel("Optimization step")`