Merge pull request #2 from ianrodrigues/patch-2

Clean up

Author: mattiasgeniar

config/.gitkeep

@@ -1,37 +1,39 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mattiasgeniar\Percentage;
 
 class Percentage
 {
     /**
      * What is the percentage increase or decrease from $a to $b ?
      */
-    public static function differenceBetween($a, $b)
+    public static function differenceBetween($a, $b): float
     {
         return floatval(($b - $a) / $a * 100);
     }
 
     /**
      * What is the absolute percentage increase or decrease from $a to $b ?
      */
-    public static function absoluteDifferenceBetween($a, $b)
+    public static function absoluteDifferenceBetween($a, $b): float
     {
         return floatval(abs(static::differenceBetween($a, $b)));
     }
 
     /**
      * How much is $a of $b in percentages?
      */
-    public static function calculate($a, $b)
+    public static function calculate($a, $b): float
     {
         return floatval($a * 100 / $b);
     }
 
     /**
      * Get a percentage return from a number.
      */
-    public static function of($percentage, $number)
+    public static function of($percentage, $number): float
     {
         return floatval($number * ($percentage / 100));
     }
@@ -41,14 +43,12 @@ public static function of($percentage, $number)
      */
     public static function extension($percentage, $a, $b): float
     {
-        if ($a > $b) {
-            $movement = $a - $b;
+        $movement = abs($a - $b);
 
+        if ($a > $b) {
             return floatval($a - ($movement * $percentage / 100));
-        } else {
-            $movement = $b - $a;
-
-            return floatval($a + ($movement * $percentage / 100));
         }
+
+        return floatval($a + ($movement * $percentage / 100));
     }
 }

src/Percentage.php

@@ -5,14 +5,8 @@
 use Mattiasgeniar\Percentage\Percentage;
 use PHPUnit\Framework\TestCase;
 
-class ExampleTest extends TestCase
+class PercentageTest extends TestCase
 {
-    /** @test */
-    public function true_is_true()
-    {
-        $this->assertTrue(true);
-    }
-
     /** @test */
     public function it_can_calculate_simple_percentage_differences()
     {