Catching 'Divide By Zero Error' and Formatting

[jamesmills]

Howdy @mattiasgeniar

Firstly, thanks for this package, saved me some time!

Nothing urgent here... I just found myself having to wrap around your function with the below to catch and format. Not sure if this is helpful for any additional feature ideas or not but thought I would share anyway.

    function percentageWrapper($a, $b, $round = true, $symbol = true)
    {
        if ($a <= 0 || $b <= 0) {
            $percentage = 0;
        } else {
            $percentage = percentage($a, $b);
        }

        if ($round) {
            $percentage = round($percentage);
        }

        if ($symbol) {
            $percentage .= '%';
        }

        return $percentage;
    }

[robertmylne]

    function percentageWrapper($a, $b, $decimals = null, $symbol = true)
    {
        if ($a == 0 || $b == 0) { // <--- we need to allow negative changes, example is stock investing.
            $percentage = 0;
        } else {
            $percentage = percentage($a, $b);
        }

        if ($decimals) {
            $percentage = ($decimals === 0) ? intval(round($percentage, decimals))  : round($percentage, decimals); // <-- allows dynamic choice of decimal places and defaults to resulting decimal places.
        }

        if ($symbol) {
            $percentage .= '%';
        }

        return $percentage;
    }

[jamesmills]

Shall I PR this? Or can you think of a better function name for it to fit with the package?

[intrepidws]

Did anything ever come of this? I'm running into the same troubles.

[mattiasgeniar]

Happy to accept a PR for this, although I'm not 100% sure what the idea end result is: if you divide by zero, it's invalid, should it just return 0? Or throw an exception to catch further down? The exception doesn't really solve the problem.