Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

withConfig not typed correctly and withContext method missing from generated machine types #92

Open
@bahalperin

Description

In xstate, withConfig is typed with context as a second, optional parameter. In xstate-codegen, the generated signature for withConfig lets you pass in context in the same object as the rest of the machine options. This ends up getting silently ignored and leads to confusing behavior.

The generated machines are also missing the withContext method. Typescript uses the original xstate method, which results in a type error because it returns the StateMachine type from xstate and not the generated machine type from xstate-codegen.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions