fix: resolve variable problems in nix shell (rancher#141)

Signed-off-by: matttrach <matt.trachier@suse.com>

Author: matttrach

.github/workflows/release.yaml

@@ -104,15 +104,16 @@ jobs:
           AWS_ACCESS_KEY_ID: ${{ steps.aws-creds.outputs.aws-access-key-id }}
           AWS_SECRET_ACCESS_KEY: ${{ steps.aws-creds.outputs.aws-secret-access-key }}
           AWS_SESSION_TOKEN: ${{ steps.aws-creds.outputs.aws-session-token }}
-          AWS_MAX_ATTEMPTS: 100
-          AWS_RETRY_MODE: adaptive
           GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
-          GITHUB_OWNER: rancher
-          IDENTIFIER: ${{github.run_id}}
           ZONE: ${{secrets.ZONE}}
-          ACME_SERVER_URL: https://acme-v02.api.letsencrypt.org/directory
-          RANCHER_INSECURE: false
+          IDENTIFIER: ${{github.run_id}}
         run: |
+          # nix ignores environment variables that are not specifically kept
+          export AWS_MAX_ATTEMPTS="100"
+          export AWS_RETRY_MODE="adaptive"
+          export GITHUB_OWNER="rancher"
+          export ACME_SERVER_URL="https://acme-v02.api.letsencrypt.org/directory"
+          export RANCHER_INSECURE="false"
           ./run_tests.sh -s
 
   cleanup:
@@ -146,9 +147,9 @@ jobs:
           AWS_ACCESS_KEY_ID: ${{ steps.aws-creds.outputs.aws-access-key-id }}
           AWS_SECRET_ACCESS_KEY: ${{ steps.aws-creds.outputs.aws-secret-access-key }}
           AWS_SESSION_TOKEN: ${{ steps.aws-creds.outputs.aws-session-token }}
-          AWS_MAX_ATTEMPTS: 100
           IDENTIFIER: ${{github.run_id}}
         run: |
+          export AWS_MAX_ATTEMPTS="100"
           ./run_tests.sh -c $IDENTIFIER
 
   report:

examples/downstream/variables.tf

@@ -43,7 +43,6 @@ variable "rancher_version" {
   description = <<-EOT
     The version of rancher to install on the rke2 cluster.
   EOT
-  default     = "2.9.1"
 }
 variable "file_path" {
   type        = string
@@ -58,15 +57,13 @@ variable "acme_server_url" {
     The ACME server URL to use for cert-manager.
     This is useful for using the Let's Encrypt staging server for testing.
   EOT
-  default     = "https://acme-staging-v02.api.letsencrypt.org/directory"
 }
 variable "runner_ip" {
   type        = string
   description = <<-EOT
     The IP of the sever running Terraform.
     Only this IP will have access to the cluster.
   EOT
-  default     = ""
 }
 variable "aws_access_key_id" {
   type        = string

test/tests/util.go

@@ -394,6 +394,7 @@ func SetAcmeServer(t *testing.T) string {
 	acmeserver := os.Getenv("ACME_SERVER_URL")
 	if acmeserver == "" {
 		os.Setenv("ACME_SERVER_URL", "https://acme-staging-v02.api.letsencrypt.org/directory") //nolint usetesting
+		acmeserver = "https://acme-staging-v02.api.letsencrypt.org/directory"
 	}
 	return acmeserver
 }