fix: lint create and destroy scripts (rancher#137)

Signed-off-by: matttrach <matt.trachier@suse.com>

Author: matttrach

modules/deploy/create.sh.tpl

@@ -1,35 +1,48 @@
+#!/usr/bin/env sh
 set -x
 DIR=$(pwd)
-cd ${deploy_path}
+# shellcheck disable=SC2154
+cd "${deploy_path}" || exit
 pwd
 ls -lah
 whoami
-. envrc
+if [ -f ./envrc ]; then
+  # shellcheck disable=SC1091
+  . ./envrc
+else
+  echo "can't find envrc..."
+  exit 1
+fi
 terraform version
 
+# shellcheck disable=SC2034
 TF_CLI_ARGS_init=""
+# shellcheck disable=SC2034
 TF_CLI_ARGS_apply=""
 
+# shellcheck disable=SC2154
 ${init_script}
 
+# shellcheck disable=SC2154
 MAX=${attempts}
 EXITCODE=1
 ATTEMPTS=0
 E=1
 E1=0
-while [ $EXITCODE -gt 0 ] && [ $ATTEMPTS -lt $MAX ]; do
+while [ $EXITCODE -gt 0 ] && [ $ATTEMPTS -lt "$MAX" ]; do
   A=0
-  while [ $E -gt 0 ] && [ $A -lt $MAX ]; do
-    timeout -k 1m ${timeout} terraform apply -var-file="inputs.tfvars" -no-color -auto-approve -state="tfstate"
+  while [ $E -gt 0 ] && [ $A -lt "$MAX" ]; do
+    # shellcheck disable=SC2154
+    timeout -k 1m "${timeout}" terraform apply -var-file="inputs.tfvars" -no-color -auto-approve -state="tfstate"
     E=$?
     if [ $E -eq 124 ]; then echo "Apply timed out after ${timeout}"; fi
     A=$((A+1))
   done
   # don't destroy if the last attempt fails
   if [ $E -gt 0 ] && [ $ATTEMPTS != $((MAX-1)) ]; then
     A1=0
-    while [ $E1 -gt 0 ] && [ $A1 -lt $MAX ]; do
-      timeout -k 1m ${timeout} terraform destroy -var-file="inputs.tfvars" -no-color -auto-approve -state="tfstate"
+    while [ $E1 -gt 0 ] && [ $A1 -lt "$MAX" ]; do
+      timeout -k 1m "${timeout}" terraform destroy -var-file="inputs.tfvars" -no-color -auto-approve -state="tfstate"
       E1=$?
       if [ $E1 -eq 124 ]; then echo "Apply timed out after ${timeout}"; fi
       A1=$((A1+1))
@@ -47,16 +60,18 @@ while [ $EXITCODE -gt 0 ] && [ $ATTEMPTS -lt $MAX ]; do
     EXITCODE=0
   fi
   ATTEMPTS=$((ATTEMPTS+1))
-  if [ $EXITCODE -gt 0 ] && [ $ATTEMPTS -lt $MAX ]; then
+  if [ $EXITCODE -gt 0 ] && [ $ATTEMPTS -lt "$MAX" ]; then
+    # shellcheck disable=SC2154
     echo "wait ${interval} seconds between attempts..."
-    sleep ${interval}
+    # shellcheck disable=SC2154
+    sleep "${interval}"
   fi
 done
-if [ $ATTEMPTS -eq $MAX ]; then echo "max attempts reached..."; fi
+if [ $ATTEMPTS -eq "$MAX" ]; then echo "max attempts reached..."; fi
 if [ $EXITCODE -ne 0 ]; then echo "failure, exit code $EXITCODE..."; fi
 if [ $EXITCODE -eq 0 ]; then
   echo "success...";
   terraform output -json -state="tfstate" > outputs.json
 fi
-cd $DIR
+cd "$DIR" || exit
 exit $EXITCODE

modules/deploy/destroy.sh.tpl

@@ -1,19 +1,33 @@
+#!/usr/bin/env sh
 set -x
 DIR=$(pwd)
-cd ${deploy_path}
+# shellcheck disable=SC2154
+cd "${deploy_path}" || exit 1
 pwd
 ls -lah
 whoami
-. envrc
+if [ -f ./envrc ]; then
+  # shellcheck disable=SC1091
+  . ./envrc
+else
+  echo "can't find envrc..."
+  exit 1
+fi
 terraform version
 
+# shellcheck disable=SC2034
 TF_CLI_ARGS_init=""
+# shellcheck disable=SC2034
 TF_CLI_ARGS_apply=""
+
+# shellcheck disable=SC2154
 if [ -z "${skip_destroy}" ]; then
-  timeout -k 1m ${timeout} terraform init -upgrade -reconfigure -no-color
-  timeout -k 1m ${timeout} terraform destroy -var-file="inputs.tfvars" -no-color -auto-approve -state="tfstate" || true
+  # shellcheck disable=SC2154
+  timeout -k 1m "${timeout}" terraform init -upgrade -reconfigure -no-color
+  # shellcheck disable=SC2154
+  timeout -k 1m "${timeout}" terraform destroy -var-file="inputs.tfvars" -no-color -auto-approve -state="tfstate" || true
 else
   echo "Not destroying deployed module, it will no longer be managed here."
 fi
-cd $DIR
+cd "$DIR" || exit 1
 exit 0