[JENKINS-75695] Pagination for item role assignments and UI refresh (jenkinsci#405)

Author: mawinter69

README.md

@@ -70,14 +70,15 @@ You can assign roles to users and user groups using the _Assign Roles_ screen
 * Hovering over a checkbox will show a tooltip with role, user/group and pattern.
 
 #### Working with many roles
-The UI becomes slow to load when working with many roles. A setup with 400 item roles and one user/group assigned to each role will result in
-a table with 160k checkboxes. This will cause a high memory consumption of the browser and loading the page will take quite long (~ 1min and more).
-To improve the loading tooltips and table highlighting are disabled when the total number of checkboxes exceeds 40000 (that is 200 roles with 200 users/groups).
+To ensure a responsive UI the item assignment works with pagination. With many roles the tooltips and the highlighter might still be a bit laggy.
+Applying a role filter will make them work smoothly usually.
 
-To further improve UI response times use the filters for users and roles.
+By default the number of rows is limited to 30 for the item role assignment page. You can change this by setting the system property
+`com.michelin.cio.hudson.plugins.rolestrategy.RoleStrategyConfig.MAX_ROWS` at jvm start or via the script console.
 
-Another limitation is that when you run Jenkins via the built-in Jetty, that the max number of parameters in a form submission is 10000 and the max formsize is 200000. This can be
-increased by passing the parameter `--maxParamCount=N` to the Jenkins java call (See the [Winstone](https://github.com/jenkinsci/winstone) documentation) and setting the system 
+The number of parameters in a form submission is limited to 10000 by default in Jenkins and the max formsize is limited to 200000 by Jetty.
+If you encounter problems when saving the "Manage Roles" due to too many form keys this can be increased by passing the parameter `--maxParamCount=N` 
+to the Jenkins java call (See the [Winstone](https://github.com/jenkinsci/winstone) documentation) and setting the system
 property `-Dorg.eclipse.jetty.server.Request.maxFormContentSize=n` at jvm start.
 
 ![Assign roles](/docs/images/assignRoles.png)
@@ -152,5 +153,4 @@ an init hook script.
 
 * [Changelog](https://github.com/jenkinsci/role-strategy-plugin/releases)
 * [Macro extensions](./docs/MACROS.md)
-* [Greasemonkey Addons for Web UI](./docs/USERSCRIPTS.md)
 * [Developer documentation](./docs/DEVELOPER.md)

docs/DEVELOPER.md

@@ -29,8 +29,10 @@ Verify that following things work on `Assign Roles`:
 2. Deleting a role by pressing on the red x deletes the role
 3. Hovering over the checkboxes properly highlights the row and column and shows a tooltip
 4. Entering html as user is printed as plain text in the field and in the tooltips.
+5. Check that pagination works especially in combination with the filters.
 
-
+Creating some hundred item roles and assignments
+Use the file [roles.groovy](roles.groovy) to generate 400 item roles and assign each role a user and a group
 
 ### Code details
 

docs/USERSCRIPTS.md

@@ -0,0 +1,32 @@
+import com.michelin.cio.hudson.plugins.rolestrategy.AuthorizationType
+import com.michelin.cio.hudson.plugins.rolestrategy.PermissionEntry
+import com.michelin.cio.hudson.plugins.rolestrategy.RoleBasedAuthorizationStrategy
+import com.michelin.cio.hudson.plugins.rolestrategy.Role
+import com.synopsys.arc.jenkins.plugins.rolestrategy.RoleType
+import hudson.security.Permission
+
+
+Jenkins jenkins = Jenkins.get()
+def rbas = jenkins.getAuthorizationStrategy()
+
+/* create admin role */
+Set<Permission> permissions = new HashSet<>();
+permissions.add(Item.READ)
+permissions.add(Item.BUILD)
+
+
+itemRoleMap = rbas.getRoleMap(RoleType.Project)
+
+for (i = 101; i <=500; i++) {
+    role = "role-"+i;
+    user = "user-"+i
+    group = "group-"+i
+    //r = new Role(role, role, permissions)
+    //itemRoleMap.addRole(r)
+    //itemRoleMap.assignRole(r, new PermissionEntry(AuthorizationType.USER, user))
+    //itemRoleMap.assignRole(r, new PermissionEntry(AuthorizationType.GROUP, group))
+    r = itemRoleMap.getRole(role)
+    itemRoleMap.removeRole(r)
+}
+
+jenkins.save()

docs/images/assignRoles.png

@@ -23,24 +23,6 @@
     </license>
   </licenses>
 
-  <developers>
-    <developer>
-      <id>tmaurel</id>
-      <name>Thomas Maurel</name>
-      <timezone>+1</timezone>
-    </developer>
-    <developer>
-      <id>rseguy</id>
-      <name>Romain Seguy</name>
-      <timezone>+1</timezone>
-    </developer>
-    <developer>
-      <id>oleg_nenashev</id>
-      <name>Oleg Nenashev</name>
-      <email>o.v.nenashev@gmail.com</email>
-    </developer>
-  </developers>
-
   <scm>
     <connection>scm:git:https://github.com/${gitHubRepo}.git</connection>
     <developerConnection>scm:git:git@github.com:${gitHubRepo}.git</developerConnection>