Sort results at the end of select_matches

Because selections may overlap, it is possible for result not to be
correctly sorted, as for example, we could be selecting '[ab]' in
'a b' selected twice, which would result in (a, b, a, b) when the
correctly sorted selection list should be (a, a, b, b).

Author: mawww

src/selectors.cc

@@ -956,7 +956,6 @@ Vector<Selection> select_matches(const Buffer& buffer, ConstArrayView<Selection>
                                                  submatch.second.coord()));
 
             auto begin = capture.first, end = capture.second;
-            kak_assert(result.empty() or begin.coord() >= result.back().min());
             result.push_back(
                 keep_direction({ begin.coord(),
                                  (begin == end ? end : utf8::previous(end, begin)).coord(),
@@ -965,6 +964,8 @@ Vector<Selection> select_matches(const Buffer& buffer, ConstArrayView<Selection>
     }
     if (result.empty())
         throw runtime_error("nothing selected");
+
+    std::sort(result.begin(), result.end(), compare_selections);
     return result;
 }
 

test/regression/0-crash-on-regex-prompt-change/cmd

@@ -0,0 +1 @@
+%5<lt><a-s><a-h><semicolon>?\S<ret>s<space>

test/regression/0-crash-on-regex-prompt-change/in

@@ -0,0 +1,2 @@
+          (
+            cd foobar

test/regression/0-crash-on-regex-prompt-change/rc

@@ -0,0 +1 @@
+set-option global indentwidth 2

test/regression/0-crash-on-regex-prompt-change/script

@@ -0,0 +1 @@
+ui_out -ignore 10