[BUG][CRASH] SIGSEGV when using kak-lsp and zls

[ifreund]

Version of Kakoune

v2021.11.08-30-g716f1f96

Reproducer

This seems to be triggered by scrolling up through quick, repeated <c-u> presses while on a video call and sharing my screen. I've reproduced this crash 3 times now in this exact scenario but have failed to reproduce it otherwise.

Outcome

Sorry for the screenshot of text, I wasn't able to copy paste from the window for whatever reason and the terminal was left in a non-functional state due to the crash so I couldn't copy-paste from there either.

Additional information

I haven't been able to reproduce this on v2021.11.08, which is the version I fell back to for my remote work for now.

[ifreund]

git log shows that there have only been two commits that touch src/command_manager.cc since the (seemingly) working v2021.11.08 tag:

$ git log v2021.11.08..HEAD src/command_manager.cc 
commit 28ac8adbfce32dc1c7de20de8bf7a2075ae3d4ef
Author: Maxime Coste <mawww@kakoune.org>
Date:   Thu Nov 25 12:23:21 2021 +1100

    Templatize parse_quoted to avoid utf8 decoding with ascii delimiter

commit 91550639bbbd20c92957b83abfbb3ec4c43b3ab4
Author: Maxime Coste <mawww@kakoune.org>
Date:   Sun Nov 21 11:15:08 2021 +1100

    More C++20 refactorings
    
    Use CTAD instead of make functions, requires instead of enable_if

This would probably be a good place to start looking for the regression.

[Screwtapello]

Can you reproduce when starting Kakoune with kak -n?

[Screwtapello]

Also, although you probably can't copy/paste in the traditional way from that dialog, if you select the text (by dragging across it in the usual way) you should be able to paste the text into GitHub by middle-clicking in the text-box (or three-finger-tapping if you're using a touchpad on Linux)

[ifreund]

Can you reproduce when starting Kakoune with kak -n?

I haven't been able to yet, but I can't reproduce this reliably enough in general to be conclusive that my config has something to do with it.

[mawww]

From the callstack, it looks like Kakoune is executing a command received via kak -p, when you get that crash again can you keep that dialog open, and attach gdb to the given PID (the point of that dialog is that it suspends the crashed Kakoune process so it is still available for inspection). once in there, I expect going up the stack would lead you to remote.cc:819, can you print the 'command' variable and report that here ?

[mralusw]

There is also, of course, the option of uploading your kakrc and all related files, so that this can get reproduced; but that might mean possibly exposing private information.

[ifreund]

There is also, of course, the option of uploading your kakrc and all related files, so that this can get reproduced; but that might mean possibly exposing private information.

It's been public since I started using kakoune https://github.com/ifreund/dotfiles/tree/trunk/config/kak

[sidkshatriya]

@ifreund I have another suggestion. Build and run kakoune with debug=yes i.e.

$ make install debug=yes

Now run kakoune like this for a few days. Hopefully you will be able to repeat this issue. And when you do, it's possible that you will fail in a kakoune assertion statement. When you run kakoune in release mode kak_assert statements are not executed. By the time the signal actually occurs it can be very difficult to figure out the root cause.

When you're able to repeat the error you'll get a stack trace that may be more actionable... Please post the stack trace here...

[ifreund]

@sidkshatriya I've been running a debug build since I reported this issue but haven't been lucky enough to reproduce it since then.

[mralusw]

It's been public since I started using kakoune https://github.com/ifreund/dotfiles/tree/trunk/config/kak

Something is missing:

git clone https://github.com/ifreund/dotfiles/ /tmp/ifr
KAKOUNE_CONFIG_DIR=/tmp/ifr/config/kak kak

debug buffer:

/tmp/ifr/config/kak/kakrc:33:1: 'set-option': option not found: 'grepcmd'. Use declare-option first
/opt/kak-v2021.11.08/share/kak/kakrc:29:1: 'evaluate-commands': 8:1: 'source': 33:1: 'set-option': option not found: 'grepcmd'. Use declare-
error while parsing kakrc:
    1:1: 'source': 29:1: 'evaluate-commands': 8:1: 'source': 33:1: 'set-option': option not found: 'grepcmd'. Use declare-option first
Error: nothing left to undo

[ifreund]

@mralusw You probably don't have your global kakoune autoload directory in the same place I do, see https://github.com/ifreund/dotfiles/blob/trunk/config/kak/autoload/default

[mralusw]

I am not a Kakoune developer, and my only personal investment here is, basically, to see kak be as robust as vim.

I see that you use a symlink, However, I'm not sure how this would work with cloning into a separate CONFIG dir, which I would need for testing purposes.