[BUG][CRASH] On buffer quit

[catdevnull]

Version of Kakoune

v2021.11.08

Reproducer

I believe it was something related to closing buffers while having multiple clients. I can't tell what it is, but it has happened at least three times now.

Outcome

[New LWP 15139]
Core was generated by `kak'.
Program terminated with signal SIGABRT, Aborted.
#0  __restore_sigs (set=set@entry=0x7ffc229ff130) at ./arch/x86_64/syscall_arch.h:40
#0  __restore_sigs (set=set@entry=0x7ffc229ff130) at ./arch/x86_64/syscall_arch.h:40
No locals.
#1  0x00007564f6e9b54c in raise (sig=sig@entry=6) at src/signal/raise.c:11
        set = {__bits = {0, 129076499696040, 129076500020888, 0, 129076498900949, 2, 0, 1, 129076500009152, 2, 129076498900949, 2, 0, 129076499703726, 18374403900871474943, 2}}
        ret = 0
#2  0x00007564f6e71f25 in abort () at src/exit/abort.c:11
No locals.
#3  0x00007564f6d44c0b in __gnu_cxx::__verbose_terminate_handler() () from /usr/lib/libstdc++.so.6
No symbol table info available.
#4  0x00007564f6d430ce in __cxxabiv1::__terminate(void (*)()) () from /usr/lib/libstdc++.so.6
No symbol table info available.
#5  0x00007564f6d422fb in __cxa_call_terminate () from /usr/lib/libstdc++.so.6
No symbol table info available.
#6  0x00007564f6d42c8d in __gxx_personality_v0 () from /usr/lib/libstdc++.so.6
No symbol table info available.
#7  0x00007564f6c74084 in ?? () from /usr/lib/libgcc_s.so.1
No symbol table info available.
#8  0x00007564f6c74721 in _Unwind_RaiseException () from /usr/lib/libgcc_s.so.1
No symbol table info available.
#9  0x00007564f6d4330b in __cxa_throw () from /usr/lib/libstdc++.so.6
No symbol table info available.
#10 0x0000567866b32ac9 in Kakoune::write (fd=580909344, fd@entry=1, data=...) at file.cc:269
        written = <optimized out>
        ptr = <optimized out>
        count = <optimized out>
#11 0x0000567866d07346 in Kakoune::TerminalUI::enable_mouse (enabled=false, this=0x7564f6b01b50) at terminal_ui.cc:1451
No locals.
#12 Kakoune::TerminalUI::~TerminalUI (this=0x7564f6b01b50, __in_chrg=<optimized out>) at terminal_ui.cc:476
No locals.
#13 0x0000567866c5a033 in Kakoune::LocalUI::~LocalUI (this=0x7564f6b01b50, __in_chrg=<optimized out>) at main.cc:661
No locals.
#14 Kakoune::LocalUI::~LocalUI (this=0x7564f6b01b50, __in_chrg=<optimized out>) at main.cc:672
No locals.
#15 0x0000567866b6bab4 in std::default_delete<Kakoune::Client>::operator() (__ptr=0x7564f6b40690, this=0x7564f6af1430) at /usr/include/c++/10.3.1/bits/unique_ptr.h:85
No locals.
#16 std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> >::~unique_ptr (this=0x7564f6af1430, __in_chrg=<optimized out>) at /usr/include/c++/10.3.1/bits/unique_ptr.h:361
        __ptr = @0x7564f6af1430: 0x7564f6b40690
#17 std::_Destroy<std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> > > (__pointer=0x7564f6af1430) at /usr/include/c++/10.3.1/bits/stl_construct.h:140
No locals.
#18 std::allocator_traits<Kakoune::Allocator<std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> >, (Kakoune::MemoryDomain)17> >::_S_destroy<Kakoune::Allocator<std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> >, (Kakoune::MemoryDomain)17>, std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> > > (__p=0x7564f6af1430) at /usr/include/c++/10.3.1/bits/alloc_traits.h:274
No locals.
#19 std::allocator_traits<Kakoune::Allocator<std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> >, (Kakoune::MemoryDomain)17> >::destroy<std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> > > (__p=0x7564f6af1430, __a=...) at /usr/include/c++/10.3.1/bits/alloc_traits.h:374
No locals.
#20 std::_Destroy<std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> >*, Kakoune::Allocator<std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> >, (Kakoune::MemoryDomain)17> > (__alloc=..., __last=<optimized out>, __first=0x7564f6af1430) at /usr/include/c++/10.3.1/bits/alloc_traits.h:728
No locals.
#21 std::vector<std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> >, Kakoune::Allocator<std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> >, (Kakoune::MemoryDomain)17> >::_M_erase_at_end (__pos=0x7564f6af1430, this=0x7ffc229ffc08) at /usr/include/c++/10.3.1/bits/stl_vector.h:1796
        __n = 1
#22 std::vector<std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> >, Kakoune::Allocator<std::unique_ptr<Kakoune::Client, std::default_delete<Kakoune::Client> >, (Kakoune::MemoryDomain)17> >::clear (this=0x7ffc229ffc08) at /usr/include/c++/10.3.1/bits/stl_vector.h:1499
No locals.
#23 Kakoune::ClientManager::clear_client_trash (this=this@entry=0x7ffc229ffbf0) at client_manager.cc:199
No locals.
[snip]

Expectations

No response

Additional information

• Alpine Linux edge
• Terminal: foot

[Screwtapello]

From the backtrace, it looks like Kakoune was shutting down a client, tried to restore the terminal state, and the terminal was already gone. When you say "closing buffers", do you mean the :delete-buffer command, :quit, or just closing the terminal Kakoune is running inside?

[catdevnull]

As far as I remember, I believe it was the equivalent of a delete-buffer.