Skip to content

Commit ae3d8ce

Browse files
authored
Wolfram Language 12.3 (#652)
## Changes * Updates the minimum required WL version to 12.3. * Removes WL prerelease tests. * Removes unnecessary backward-compatibility code. ## Comments * This allows us to use WL 12.3 features without any restrictions.
1 parent 422eec4 commit ae3d8ce

7 files changed

Lines changed: 7 additions & 44 deletions

File tree

.circleci/config.yml

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ orbs:
66
jobs:
77
wolfram-language-paclet-test:
88
docker:
9-
- image: maxitg/set-replace-wl-ci:12.2.0
9+
- image: maxitg/set-replace-wl-ci:12.3.0
1010
auth:
1111
username: maxitg
1212
password: $DOCKERHUB_PASSWORD
@@ -52,32 +52,6 @@ jobs:
5252
./performanceTest.wls master HEAD 2
5353
fi
5454
55-
wolfram-language-paclet-test-prerelease:
56-
docker:
57-
- image: maxitg/set-replace-wl-ci:12.3.0
58-
auth:
59-
username: maxitg
60-
password: $DOCKERHUB_PASSWORD
61-
parallelism: 4
62-
63-
steps:
64-
- checkout
65-
66-
- attach_workspace:
67-
at: /tmp/workspace
68-
69-
- run:
70-
name: Copy libraries
71-
command: mkdir -p ./LibraryResources && cp -r /tmp/workspace/* ./LibraryResources/
72-
73-
- run:
74-
name: Install
75-
command: ./install.wls
76-
77-
- run:
78-
name: Test
79-
command: ./.circleci/test.sh
80-
8155
cpp-test:
8256
docker:
8357
- image: alpine:3.12.1
@@ -228,6 +202,3 @@ workflows:
228202
requires:
229203
- macos-build
230204
- windows-build
231-
- wolfram-language-paclet-test-prerelease:
232-
requires:
233-
- wolfram-language-paclet-test

DevUtils/GitLink.m

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
PackageImport["GeneralUtilities`"]
44

5-
PackageImport["PacletManager`"] (* for PacletFind, PacletInstall in versions prior to 12.1 *)
6-
75
PackageExport["$GitLinkAvailableQ"]
86
PackageExport["GitSHAWithDirtyStar"]
97
PackageExport["InstallGitLink"]

DevUtils/PackSetReplace.m

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,18 +71,13 @@
7171

7272
fileInputs = {kernelDir, libraryDir, pacletInfoFile, tempBuildInfoFile};
7373

74-
pacletCreatorFunction = If[$VersionNumber >= 12.1,
75-
Symbol["System`CreatePacletArchive"]
76-
,
77-
Symbol["PacletManager`PackPaclet"]
78-
];
79-
pacletFileName = pacletCreatorFunction[fileInputs, outputDirectory];
74+
pacletFileName = CreatePacletArchive[fileInputs, outputDirectory];
8075

8176
If[StringQ[pacletFileName],
8277
If[verbose,
8378
Print["Paclet file written to ", pacletFileName]
8479
];
85-
Return @ If[$VersionNumber >= 12.1, PacletObject[File[pacletFileName]], <|"Location" -> pacletFileName|>]
80+
Return @ PacletObject[File[pacletFileName]]
8681
,
8782
If[verbose, Print["Pack failed."]];
8883
ReturnFailed["packfailed", sourceDirectory, outputDirectory]

Kernel/convexHullPolygon.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
(pt2[[1]] - pt1[[1]]) (pt3[[2]] - pt2[[2]]) - (pt2[[2]] - pt1[[2]]) (pt3[[1]] - pt2[[1]]);
2121

2222
convexHullPolygon[points_] := ModuleScope[
23-
(* Sort is broken for symbolic values in Wolfram Language 12.2 *)
23+
(* Sort uses lexicographic rather than numeric ordering, so it might not work if the points are not numeric. *)
2424
numericPoints = N[points];
2525
stack = CreateDataStructure["Stack"];
2626
(* find a bottommost point, if multiple, find the leftmost one *)

PacletInfo.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Paclet[
44
Name -> "SetReplace",
55
Version -> "0.3",
6-
MathematicaVersion -> "12.2+",
6+
MathematicaVersion -> "12.3+",
77
Description -> "SetReplace implements WolframModel and other functions used in the Wolfram Physics Project.",
88
Creator -> "Wolfram Research",
99
URL -> "https://github.com/maxitg/SetReplace",

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Out[] = {5, 3, 6, 3}
2929
```
3030

3131
Note that this is similar to [`SubsetReplace`](https://reference.wolfram.com/language/ref/SubsetReplace.html) function
32-
of Wolfram Language (introduced in version 12.1, it replaces all non-overlapping subsets at once by default):
32+
of Wolfram Language (it replaces all non-overlapping subsets at once by default):
3333

3434
```wl
3535
In[] := SubsetReplace[{1, 2, 5, 3, 6}, {a_, b_} :> a + b]
@@ -110,7 +110,7 @@ You only need three things to use *SetReplace*:
110110
* Windows, macOS 10.12+, or Linux.
111111
* Windows only &mdash;
112112
[Microsoft Visual C++ Redistributable 2015+](https://support.microsoft.com/en-us/topic/the-latest-supported-visual-c-downloads-2647da03-1eea-4433-9aff-95f26a218cc0).
113-
* [Wolfram Language 12.2+](https://www.wolfram.com/language/)
113+
* [Wolfram Language 12.3+](https://www.wolfram.com/language/)
114114
including [WolframScript](https://www.wolfram.com/wolframscript/). A free version is available
115115
as [Wolfram Engine](https://www.wolfram.com/engine/).
116116
* A C++17 compiler to build the low-level part of the package. Instructions on how to set up a compiler to use in

install.wls

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
Check[
44
Get[FileNameJoin[{DirectoryName[$InputFileName], "DevUtils", "init.m"}]];
55
Off[General::stop];
6-
If[$VersionNumber < 12.1, Needs["PacletManager`"]];
76
,
87
Print["Message occurred during loading of DevUtils. Build failed."];
98
Exit[1];

0 commit comments

Comments
 (0)