Skip to content

Commit b049a8b

Browse files
committed
feat(nodes/oscillator): only show relevant settings
* show ratio only for square oscillator type * hide reverse until implemented
1 parent 4b22ae6 commit b049a8b

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

  • crates/runtime/pipeline/nodes/behaviors/oscillator/src

‎crates/runtime/pipeline/nodes/behaviors/oscillator/src/lib.rs‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ fn default_ratio() -> f64 {
7070

7171
impl ConfigurableNode for OscillatorNode {
7272
fn settings(&self, _injector: &Injector) -> Vec<NodeSetting> {
73-
vec![
73+
let mut settings = vec![
7474
setting!(enum TYPE_SETTING, self.oscillator_type),
7575
setting!(INTERVAL_SETTING, self.interval)
7676
.min(0.)
@@ -86,9 +86,12 @@ impl ConfigurableNode for OscillatorNode {
8686
setting!(OFFSET_SETTING, self.offset)
8787
.min_hint(0.)
8888
.max_hint(1.),
89-
setting!(RATIO_SETTING, self.ratio).min(0.).max(1.),
90-
setting!(REVERSE_SETTING, self.reverse),
91-
]
89+
];
90+
if matches!(self.oscillator_type, OscillatorType::Square) {
91+
settings.push(setting!(RATIO_SETTING, self.ratio).min(0.).max(1.));
92+
}
93+
94+
settings
9295
}
9396

9497
fn update_setting(&mut self, setting: NodeSetting) -> anyhow::Result<()> {

0 commit comments

Comments
 (0)