fix(certificates): plugin crashes because of invalid certificate resource layout

Author: maxjoehnk

provider/data_source_iis_certificates.go

@@ -69,16 +69,21 @@ func dataSourceIisCertificatesRead(ctx context.Context, d *schema.ResourceData,
 }
 
 func mapCertificatesToSet(certificates []iis.Certificate) *schema.Set {
-	result := schema.NewSet(schema.HashString, []interface{}{})
+	var set []interface{}
 	for _, certificate := range certificates {
-		mapped := map[string]interface{}{
+		set = append(set, map[string]interface{}{
 			AliasKey:      certificate.Alias,
 			IdKey:         certificate.ID,
 			IssuedByKey:   certificate.IssuedBy,
 			SubjectKey:    certificate.Subject,
 			ThumbprintKey: certificate.Thumbprint,
-		}
-		result.Add(mapped)
+		})
 	}
-	return result
+	return schema.NewSet(hashCertificate, set)
+}
+
+func hashCertificate(v interface{}) int {
+	certificateMap := v.(map[string]interface{})
+
+	return schema.HashString(certificateMap[IdKey].(string))
 }

provider/data_source_iis_certificates_test.go

@@ -0,0 +1,41 @@
+package provider
+
+import (
+	"os"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+func testAccPreCheck(t *testing.T) {
+	if v := os.Getenv("IIS_HOST"); v == "" {
+		t.Skip("IIS_HOST must be set for acceptance tests")
+	}
+	if v := os.Getenv("IIS_ACCESS_KEY"); v == "" {
+		t.Skip("IIS_ACCESS_KEY must be set for acceptance tests")
+	}
+}
+
+func TestAccDataSourceIisCertificates_basic(t *testing.T) {
+	resource.Test(t, resource.TestCase{
+		PreCheck: func() { testAccPreCheck(t) },
+		ProviderFactories: map[string]func() (*schema.Provider, error){
+			"iis": func() (*schema.Provider, error) {
+				return Provider(), nil
+			},
+		},
+		Steps: []resource.TestStep{
+			{
+				Config: testAccDataSourceIisCertificatesConfig,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttrSet("data.iis_certificates.test", "certificates.#"),
+				),
+			},
+		},
+	})
+}
+
+const testAccDataSourceIisCertificatesConfig = `
+data "iis_certificates" "test" {}
+`

provider/provider.go

@@ -15,12 +15,16 @@ func Provider() *schema.Provider {
 	return &schema.Provider{
 		Schema: map[string]*schema.Schema{
 			"access_key": {
-				Type:     schema.TypeString,
-				Required: true,
+				Type:        schema.TypeString,
+				Optional:    true,
+				DefaultFunc: schema.EnvDefaultFunc("IIS_ACCESS_KEY", nil),
+				Description: "The access key for IIS authentication. Can also be sourced from the IIS_ACCESS_KEY environment variable.",
 			},
 			"host": {
-				Type:     schema.TypeString,
-				Required: true,
+				Type:        schema.TypeString,
+				Optional:    true,
+				DefaultFunc: schema.EnvDefaultFunc("IIS_HOST", nil),
+				Description: "The IIS host URL. Can also be sourced from the IIS_HOST environment variable.",
 			},
 		},
 		ResourcesMap: map[string]*schema.Resource{
@@ -38,6 +42,30 @@ func Provider() *schema.Provider {
 }
 
 func providerConfigure(ctx context.Context, d *schema.ResourceData) (interface{}, diag.Diagnostics) {
+	var diags diag.Diagnostics
+
+	host := d.Get("host").(string)
+	if host == "" {
+		diags = append(diags, diag.Diagnostic{
+			Severity: diag.Error,
+			Summary:  "Missing IIS Host",
+			Detail:   "The IIS host must be configured via the 'host' argument or IIS_HOST environment variable.",
+		})
+	}
+
+	accessKey := d.Get("access_key").(string)
+	if accessKey == "" {
+		diags = append(diags, diag.Diagnostic{
+			Severity: diag.Error,
+			Summary:  "Missing IIS Access Key",
+			Detail:   "The IIS access key must be configured via the 'access_key' argument or IIS_ACCESS_KEY environment variable.",
+		})
+	}
+
+	if diags.HasError() {
+		return nil, diags
+	}
+
 	transport := &http.Transport{
 		TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
 	}
@@ -46,8 +74,8 @@ func providerConfigure(ctx context.Context, d *schema.ResourceData) (interface{}
 		HttpClient: http.Client{
 			Transport: loggingTransport,
 		},
-		Host:      d.Get("host").(string),
-		AccessKey: d.Get("access_key").(string),
+		Host:      host,
+		AccessKey: accessKey,
 	}
 
 	return client, nil