feat: SRTM pre-filter

Author: maxneuvians

valentine/lib/valentine_web/live/workspace_live/components/filter_component.ex

@@ -8,7 +8,14 @@ defmodule ValentineWeb.WorkspaceLive.Components.FilterComponent do
       if !Map.has_key?(assigns.filters, assigns.name) do
         assign(assigns, :filters, Map.put(assigns.filters, assigns.name, []))
       else
-        assigns
+        # Filter any values that are not in the list of atomic values
+        assign(
+          assigns,
+          :filters,
+          Map.update!(assigns.filters, assigns.name, fn values ->
+            Enum.filter(values, &(&1 in assigns.values))
+          end)
+        )
       end
 
     ~H"""

valentine/lib/valentine_web/live/workspace_live/srtm/index.ex

@@ -9,12 +9,18 @@ defmodule ValentineWeb.WorkspaceLive.SRTM.Index do
   @impl true
   def mount(%{"workspace_id" => workspace_id} = _params, _session, socket) do
     workspace = get_workspace(workspace_id)
-    controls = filter_controls(%{})
+
+    filters = %{
+      profile: [workspace.cloud_profile],
+      type: [workspace.cloud_profile_type]
+    }
+
+    controls = filter_controls(filters)
 
     {:ok,
      socket
      |> assign(:controls, map_controls(controls, workspace))
-     |> assign(:filters, %{})
+     |> assign(:filters, filters)
      |> assign(:workspace, workspace)}
   end
 
@@ -100,7 +106,18 @@ defmodule ValentineWeb.WorkspaceLive.SRTM.Index do
     do: Composer.list_controls()
 
   defp filter_controls(filters) do
-    filters = Map.values(filters) |> List.flatten()
+    # This should be dynamically generated
+    valid_tags = [
+      "CCCS Low Profile for Cloud",
+      "CCCS Medium Profile for Cloud",
+      "CSP Full Stack",
+      "CSP Stacked PaaS",
+      "CSP Stacked SaaS",
+      "Client IaaS / PaaS",
+      "Client SaaS"
+    ]
+
+    filters = Map.values(filters) |> List.flatten() |> Enum.filter(&(&1 in valid_tags))
     Composer.list_controls_by_tags(filters)
   end
 

valentine/test/valentine_web/live/components/filter_component_test.exs

@@ -40,6 +40,14 @@ defmodule ValentineWeb.WorkspaceLive.Components.FilterComponentTest do
       assert html =~ "filter"
     end
 
+    test "removes any selected field that are not actually in the values list", %{
+      assigns: assigns
+    } do
+      assigns = Map.put(assigns, :filters, Map.put(assigns.filters, :filter, [:four]))
+      html = render_component(FilterComponent, assigns)
+      refute html =~ "four"
+    end
+
     test "renders a counter if a filter has values", %{assigns: assigns} do
       assigns = Map.put(assigns, :filters, Map.put(assigns.filters, :filter, ["one"]))
       html = render_component(FilterComponent, assigns)

valentine/test/valentine_web/live/workspace/srtm/index_test.exs

@@ -5,7 +5,7 @@ defmodule ValentineWeb.WorkspaceLive.SRTM.IndexTest do
 
   setup do
     control = control_fixture(%{nist_id: "AC-1", tags: ["A", "B", "C"]})
-    workspace = workspace_fixture()
+    workspace = workspace_fixture(%{cloud_profile: "A", cloud_profile_type: "B"})
 
     workspace =
       Valentine.Composer.get_workspace!(workspace.id,

valentine/test/valentine_web/live/workspace/srtm/index_view_test.exs

@@ -5,8 +5,8 @@ defmodule ValentineWeb.WorkspaceLive.SRTM.IndexViewTest do
   import Valentine.ComposerFixtures
 
   setup do
-    control = control_fixture()
-    workspace = workspace_fixture()
+    control = control_fixture(%{nist_id: "AC-1", tags: ["A", "B", "C"]})
+    workspace = workspace_fixture(%{cloud_profile: "A", cloud_profile_type: "B"})
 
     %{
       control: control,