Very laggy

[hyzyycyl-cmd]

Checklist

• I have looked at the common issues and ways to fix them in the wiki
• I have searched the existing issues for the same bug
• I have attached the log file as an attachment to this issue

Describe the bug

The status viewer and local favorites are very laggy.

Steps To Reproduce

After clicking to enter the status viewer, scrolling up and down is very laggy.

Expected behavior

Scrolling up and down in the status viewer is smooth

Screenshots

无

Android Version

XX

App Version

4.2.0

Additional context

无

[locked-fog]

same there

[maxwai]

Can reproduce on the local favorite Tab. Can't reproduce on the status view. Hopefully both are linked to the same problem. I may have an idea where the Problem comes from. It may come from the main thread waiting for the network thread to load the cover images.

However, except for the first run where the favorites need to be ported to the new scheme, the lagging shouldn't be anything new since the way the covers are fetched for the favorites has not changed.

Will look at it in details once I have more time.

[maxwai]

Please check if 4.2.1 fixed the lag spikes. For me they are gone but I also didn't have very large lags during testing anyway so I'm not sure if they are fixed.

[hyzyycyl-cmd]

After migrating the data again, the status viewer is still lagging.

[maxwai]

Ok, in that case I will need to do a more in depth performance analysis when I eventually have more time.

[hyzyycyl-cmd]

I am using an automated script to click through each page of my local favorites to refresh and remove old covers, in order to verify whether it affects the smoothness of scrolling up and down in the status viewer.

[hyzyycyl-cmd]

好的，既然如此，等我有更多时间的时候，我需要做一次更深入的性能分析。
After clearing the expired local favorites, the status viewer has returned to normal.

[chanhh01]

I think need to make the check expired local favourites function available for all users

What I found out:

1. (Also based on what hyzyycyl-cmd found) Those with expired favourites will be laggy
2. They would not display the cover and has 0 pages according to the favourites.
3. But they are not deleted from the gallery. Tried searching an exact one and I can still find it online here.
4. After clicking on that said doujin (it stays favourite without my action), later it was found active and interact able back in favourites and also status viewer