Skip to content

Commit 9fe0355

Browse files
committed
review
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
1 parent 200efe7 commit 9fe0355

3 files changed

Lines changed: 20 additions & 10 deletions

File tree

test/e2e/configs_test.go

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package e2e
22

3+
import "fmt"
4+
35
// Simple EPP configuration for running without P/D
46
const simpleConfig = `apiVersion: llm-d.ai/v1alpha1
57
kind: EndpointPickerConfig
@@ -179,15 +181,17 @@ schedulingProfiles:
179181
weight: 2
180182
`
181183

182-
// EPP config for running with precise prefix scoring (i.e. KV events).
183-
const kvConfig = `apiVersion: llm-d.ai/v1alpha1
184+
// kvConfig returns the EPP config for running with precise prefix scoring (i.e. KV events).
185+
// The render URL is built from vllmRenderPort so VLLM_RENDER_PORT is respected.
186+
func kvConfig() string {
187+
return fmt.Sprintf(`apiVersion: llm-d.ai/v1alpha1
184188
kind: EndpointPickerConfig
185189
plugins:
186190
- type: token-producer
187191
parameters:
188192
modelName: Qwen/Qwen2.5-1.5B-Instruct
189193
vllm:
190-
url: http://vllm-render:8082
194+
url: http://vllm-render:%s
191195
- type: precise-prefix-cache-scorer
192196
parameters:
193197
tokenProcessorConfig:
@@ -209,17 +213,20 @@ schedulingProfiles:
209213
- pluginRef: max-score-picker
210214
- pluginRef: precise-prefix-cache-scorer
211215
weight: 10
212-
`
216+
`, vllmRenderPort)
217+
}
213218

214-
// Alias of kvConfig retained for tests that reference the external-tokenizer name.
215-
const kvExternalTokenizerConfig = `apiVersion: llm-d.ai/v1alpha1
219+
// kvExternalTokenizerConfig returns the EPP config for the external-tokenizer DataProducer variant.
220+
// The render URL is built from vllmRenderPort so VLLM_RENDER_PORT is respected.
221+
func kvExternalTokenizerConfig() string {
222+
return fmt.Sprintf(`apiVersion: llm-d.ai/v1alpha1
216223
kind: EndpointPickerConfig
217224
plugins:
218225
- type: token-producer
219226
parameters:
220227
modelName: Qwen/Qwen2.5-1.5B-Instruct
221228
vllm:
222-
url: http://vllm-render:8082
229+
url: http://vllm-render:%s
223230
- type: precise-prefix-cache-scorer
224231
parameters:
225232
tokenProcessorConfig:
@@ -240,7 +247,8 @@ schedulingProfiles:
240247
- pluginRef: max-score-picker
241248
- pluginRef: precise-prefix-cache-scorer
242249
weight: 10
243-
`
250+
`, vllmRenderPort)
251+
}
244252

245253
// EPP configuration for running scale model server test
246254
const scaleConfig = `apiVersion: llm-d.ai/v1alpha1

test/e2e/e2e_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -774,7 +774,7 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
774774
ginkgo.It("should run successfully", func() {
775775
infPoolObjects = createInferencePool(1, true)
776776

777-
epp := createEndPointPicker(kvConfig)
777+
epp := createEndPointPicker(kvConfig())
778778

779779
modelServers := createModelServersDecodeKV(1)
780780
time.Sleep(5 * time.Second) // wait for model server(s) to become ready
@@ -798,7 +798,7 @@ var _ = ginkgo.Describe("Run end to end tests", ginkgo.Ordered, func() {
798798
ginkgo.It("should run successfully", func() {
799799
infPoolObjects = createInferencePool(1, true)
800800

801-
epp := createEndPointPicker(kvExternalTokenizerConfig)
801+
epp := createEndPointPicker(kvExternalTokenizerConfig())
802802

803803
modelServers := createModelServersDecodeKV(1)
804804
time.Sleep(5 * time.Second) // wait for model server(s) to become ready

test/e2e/setup_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ func createModelServersFromKustomize(kustomizeDir string, extra map[string]strin
3434
"${VLLM_EXTRA_ARGS_E}": "--force-dummy-tokenizer",
3535
"${VLLM_EXTRA_ARGS_P}": "--force-dummy-tokenizer",
3636
"${VLLM_EXTRA_ARGS_D}": "--force-dummy-tokenizer",
37+
"${VLLM_RENDER_URL}": fmt.Sprintf("http://vllm-render.%s.svc.cluster.local:%s", nsName, vllmRenderPort),
38+
"${VLLM_RENDER_PORT}": vllmRenderPort,
3739
}
3840
for k, v := range extra {
3941
subs[k] = v

0 commit comments

Comments
 (0)