Skip to content

Commit be11c66

Browse files
author
mayankmetha
committed
removed version hardcoding
1 parent 0cfb9a5 commit be11c66

8 files changed

Lines changed: 16 additions & 6 deletions

File tree

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ android {
88
minSdkVersion 19
99
targetSdkVersion 28
1010
versionCode 1
11-
versionName "1.0"
11+
versionName "1.1"
1212
}
1313
buildTypes {
1414
release {

app/src/main/java/com/mayank/rucky/RootSettingsFragment.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package com.mayank.rucky;
22

33
import android.content.SharedPreferences;
4+
import android.content.pm.PackageInfo;
5+
import android.content.pm.PackageManager;
46
import android.os.Bundle;
57

68
import androidx.preference.Preference;
@@ -15,6 +17,7 @@ public class RootSettingsFragment extends PreferenceFragmentCompat {
1517

1618
private static final String PREF_SETTINGS = "settings";
1719
private static final String PREF_SETTINGS_DARK_THEME = "darkTheme";
20+
private static double currentVersion;
1821

1922
@Override
2023
public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
@@ -31,5 +34,13 @@ public boolean onPreferenceChange(Preference preference, Object newValue) {
3134
return true;
3235
}
3336
});
37+
try {
38+
PackageInfo pInfo = Objects.requireNonNull(this.getActivity()).getPackageManager().getPackageInfo(Objects.requireNonNull(this.getActivity()).getPackageName(), 0);
39+
currentVersion = Double.parseDouble(pInfo.versionName);
40+
} catch (PackageManager.NameNotFoundException e) {
41+
e.printStackTrace();
42+
}
43+
Preference versionPreference = findPreference("version");
44+
versionPreference.setSummary(Double.toString(currentVersion));
3445
}
3546
}

app/src/main/res/values/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
<string name="setting_developer_title">Developer</string>
88
<string name="setting_developer">Mayank Metha D</string>
99
<string name="settings_version_title">Version</string>
10-
<string name="setting_version">1.0</string>
1110
<string name="setting_about">About</string>
1211
<string name="update_name">Update</string>
1312
<string name="loadBtn">Load</string>

app/src/main/res/xml/settings.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@
2424
<Preference
2525
app:key="version"
2626
app:icon="@drawable/ic_version"
27-
app:title="@string/settings_version_title"
28-
app:summary="@string/setting_version" />
27+
app:title="@string/settings_version_title" />
2928

3029
</PreferenceCategory>
3130

release/1.1/rucky-1.1.apk

1.31 MB
Binary file not shown.

release/1.1/rucky-1.1.sha512

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
3ddf89cd72a8d7e349bf540d36673cb2c4849a6b6d568b31c0466bb948dabd82eac83a02c2cd43f0e008621c60a212a67dbb56b213e8e68ab4ba4a8b67e326b6

release/rucky.sha512

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1a75ba683aed31b863dac78742678821e6738aa352f443ef90954f79128a4eff42d4f60d1731cabbf20559a77cead303ee0620cdbc00ebb23e73dc727e3a99d2
1+
3ddf89cd72a8d7e349bf540d36673cb2c4849a6b6d568b31c0466bb948dabd82eac83a02c2cd43f0e008621c60a212a67dbb56b213e8e68ab4ba4a8b67e326b6

release/version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.0
1+
1.1

0 commit comments

Comments
 (0)