✅ [#6] Add tests for PDF generation

sergei-maertens · sergei-maertens · commit 56c9472d1259 · 2025-06-05T23:22:19.000+02:00
diff --git a/maykin_common/pdf.py b/maykin_common/pdf.py
@@ -134,7 +134,7 @@ def get_match_candidate(
         return None
 
 
-def render_to_pdf(template_name: str, context: dict) -> tuple[str, bytes]:
+def render_to_pdf(template_name: str, context: dict[str, object]) -> tuple[str, bytes]:
     """
     Render a (HTML) template to PDF with the given context.
     """
diff --git a/testapp/static/testapp/some.css b/testapp/static/testapp/some.css
@@ -0,0 +1,3 @@
+:root {
+    --color-primary: purple;
+}
diff --git a/testapp/templates/testapp/pdf/external_url.html b/testapp/templates/testapp/pdf/external_url.html
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html>
+    <head>
+        <meta charset="utf-8">
+        <meta name="viewport" content="width=device-width, initial-scale=1">
+        <title>External URL</title>
+        <link href="https://example.com/index.css" rel="stylesheet">
+    </head>
+    <body>
+        External URL.
+    </body>
+</html>
diff --git a/testapp/templates/testapp/pdf/hello_world.html b/testapp/templates/testapp/pdf/hello_world.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+    <head>
+        <meta charset="utf-8">
+        <meta name="viewport" content="width=device-width, initial-scale=1">
+        <title>Hello world</title>
+    </head>
+    <body>
+        Hello {{ world }}.
+    </body>
+</html>
diff --git a/testapp/templates/testapp/pdf/local_url.html b/testapp/templates/testapp/pdf/local_url.html
@@ -0,0 +1,14 @@
+{% load static %}
+<!DOCTYPE html>
+<html>
+    <head>
+        <meta charset="utf-8">
+        <meta name="viewport" content="width=device-width, initial-scale=1">
+        <title>Local URL</title>
+        <link href="http://testserver/static/testapp/some.css" rel="stylesheet">
+        <link href="{% static 'testapp/some.css' %}" rel="stylesheet">
+    </head>
+    <body>
+        Local URL.
+    </body>
+</html>
diff --git a/tests/pdf/test_pdf_generation.py b/tests/pdf/test_pdf_generation.py
@@ -0,0 +1,43 @@
+from unittest.mock import patch
+
+import pytest
+
+from maykin_common.pdf import render_to_pdf
+
+
+def get_base_url():
+    return "http://testserver"
+
+
+@pytest.fixture(autouse=True)
+def _settings(settings):
+    settings.PDF_BASE_URL_FUNCTION = f"{__name__}.get_base_url"
+
+
+def test_raises_if_setting_not_configured_properly(settings):
+    settings.PDF_BASE_URL_FUNCTION = None
+
+    with pytest.raises(NotImplementedError):
+        render_to_pdf("testapp/pdf/hello_world.html", {})
+
+
+def test_render_template_returns_html():
+    html, pdf = render_to_pdf("testapp/pdf/hello_world.html", {"world": "pytest"})
+
+    assert isinstance(html, str)
+    assert "Hello pytest" in html
+    assert isinstance(pdf, bytes)
+
+
+def test_external_url_uses_default_resolver():
+    with patch("maykin_common.pdf.weasyprint.default_url_fetcher") as mock_fetcher:
+        render_to_pdf("testapp/pdf/external_url.html", {})
+
+    mock_fetcher.assert_called_once_with("https://example.com/index.css")
+
+
+def test_local_asset_does_not_use_default_resolver():
+    with patch("maykin_common.pdf.weasyprint.default_url_fetcher") as mock_fetcher:
+        render_to_pdf("testapp/pdf/local_url.html", {})
+
+    mock_fetcher.assert_not_called()

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+:root {`
	`2`	`+ --color-primary: purple;`
	`3`	`+}`