Skip to content

Commit e609f4f

Browse files
committed
fix: [#2099] concurrency constraint for Storybook should only be on deploy
The concurrency constraint applied to all Storybook builds, not just deploys, which meant that you would sometimes get failing storybook CI on feature branches, where the build step is required to succeed.
1 parent 7a7f54f commit e609f4f

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/storybook.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ on:
1515
- ready_for_review
1616
workflow_dispatch:
1717

18-
# Allow one concurrent deployment
19-
concurrency:
20-
group: 'pages-${{ github.ref_name }}' # unique builds for branch/tag name
21-
cancel-in-progress: true
22-
2318
jobs:
2419
storybook:
2520
name: Create storybook build
@@ -48,6 +43,11 @@ jobs:
4843
pages: write
4944
id-token: write
5045

46+
# Allow one concurrent deployment
47+
concurrency:
48+
group: 'pages-${{ github.ref_name }}' # unique builds for branch/tag name
49+
cancel-in-progress: true
50+
5151
runs-on: ubuntu-latest
5252
if: github.ref == 'refs/heads/develop' && github.event_name == 'push' # Exclude PRs
5353
needs: storybook

0 commit comments

Comments
 (0)